-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source/network: refactor readIfaceInfo #1452
source/network: refactor readIfaceInfo #1452
Conversation
Make the function more generic and re-usable.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @ArangoGutierrez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds better! Thanks!
@AhmedGrati feel free to lgtm if you think it's good to merge 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 37e873b435f3f3701a454f1ec5ad6884ed2ae8af
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
+ Coverage 30.52% 30.55% +0.02%
==========================================
Files 58 58
Lines 7534 7527 -7
==========================================
Hits 2300 2300
+ Misses 4985 4978 -7
Partials 249 249
|
Make the function more generic and re-usable.