Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prowjob CRD is too large to apply #256

Open
BenTheElder opened this issue Aug 21, 2024 · 2 comments
Open

prowjob CRD is too large to apply #256

BenTheElder opened this issue Aug 21, 2024 · 2 comments

Comments

@BenTheElder
Copy link
Member

We're including all of the descriptions of pod fields in the embedded podspec, I think we can just drop those and have a single top level description pointing to the upstream pod type?

see: kubernetes/kubernetes#54579 (comment)

cc @jpbetz

the CRD is in https://github.com/kubernetes-sigs/prow/blob/main/config/prow/cluster/prowjob-crd/prowjob_customresourcedefinition.yaml

We ran into this while spinning up the new k8s infra instance today.

It looks like SSA is being used as a workaround:
https://github.com/kubernetes/test-infra/blob/ccb09026bddecdc4ff7089f34027897d0e764d5d/config/prow/Makefile#L35

@matthyx
Copy link
Contributor

matthyx commented Aug 22, 2024

cross linking previous issue #181

@xrstf
Copy link
Contributor

xrstf commented Oct 13, 2024

It's ugly and brute force, but one could also strip all descriptions from the YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants