-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trimaran common function minor bug fix #636
Comments
/assign @atantawi @wangchen615 could you please help take a look at the issue and PR? |
@Huang-Wei: GitHub didn't allow me to assign the following users: atantawi. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @atantawi |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Area
Other components
No response
What happened?
This issue fixes below minor bugs found during code walk through:
OnDelete()
needs to delete a node fromScheduledPodsCache
if the pod being deleted is the last one associated with that node.cleanupCache()
deletes older entries. The variableidx
represents the index of the first element whose timestamp is within the current interval (assuming the entries are in ascending order of timestamps). Whenidx == len(cache)
, all the entries are to be deleted as it indicates that all the elements are older. However, the code currently doesn't delete any element if all the entries are older.What did you expect to happen?
The issues above are functionality bugs.
idx == len(cache)
to address the Bug-2 reported above, then entries outside of the current interval continue to be part of the cache.How can we reproduce it (as minimally and precisely as possible)?
Test cases were added to reproduce these issues. Without the changes to the file
scheduler-plugins/pkg/trimaran/handler.go
, the test cases that are added as specified above will fail.Anything else we need to know?
No response
Kubernetes version
Scheduler Plugins version
The text was updated successfully, but these errors were encountered: