-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trimaran test cases for common functions #635
Conversation
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
Hi @knarayan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @atantawi |
@knarayan: GitHub didn't allow me to assign the following users: atantawi. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test we don't usually accept merge commits. Can you please rebase? |
Yup, there is a prow plugin to fail on merge commit. Let me find the prow config and enable it in scheduler-plugins' CI. |
Interesting... this has been enabled https://github.com/kubernetes/test-infra/blob/de81fb13d864ccbd974e73825919a84693dca732/config/prow/plugins.yaml#L1544 |
Done rebase. |
I created #637 to track the netlify issue. |
hi @knarayan, I have checked your branch, and it seems that your branch is far way behind the master, You have to do the rebase to base on top of the master from this ![]() |
@knarayan it seems that you did a wrong rebase? I would suggest you create a brand new branch from sigs/scheduler-plugins, and cherry-pick(sorry for involving one more new command) your commit to the new branch, and then you could force push it to the branch here. |
@zwpaper I suppose that it is fixed now. Thank you. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
/lgtm |
@knarayan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@knarayan could you fix the UT failures? /approve cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knarayan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Please refer to the issue #636
Which issue(s) this PR fixes:
Fixes #636
Special notes for your reviewer:
Does this PR introduce a user-facing change?