Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw update to 1.24.2 #1826

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fw update to 1.24.2 #1826

merged 1 commit into from
Jul 1, 2022

Conversation

sashrith
Copy link
Contributor

@sashrith sashrith commented Jun 25, 2022

What this PR does / why we need it: fw update to 1.24.2

Testing done:
https://gist.github.com/sashrith/59e74ac1bea559752a058da6a8699586
there are logs from two runs here

In the first run the image was built from this PR but has some failures. All snapshot tests failed since deploy-csi-snapshot-components.sh was not run and all pod related test failed due to kubernetes/kubernetes#109283

I've fixed the issues seen for first run before the second run. In second run there are 3 failures - 1 due to apiserver crash, 1 testbed issue (kubeconfig file was not in path in all control plans nodes), 1 - I think it is not related to this change and has to be triaged further

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 25, 2022
default existing tests to privileged pod security policy
@sashrith sashrith changed the title [WIP] fw update to 1.24.2 fw update to 1.24.2 Jul 1, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@sashrith
Copy link
Contributor Author

sashrith commented Jul 1, 2022

/cc @chethanv28 @divyenpatel can you please review this PR instead of #1828 for master branch k8s framework upgrade. Almost similar changes.

@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 1, 2022
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, sashrith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 93ba6b6 into kubernetes-sigs:master Jul 1, 2022
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants