-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated storage class annotations #2385
Fix deprecated storage class annotations #2385
Conversation
Hi @rpanduranga. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
85765a6
to
88197dc
Compare
88197dc
to
e4a6f5a
Compare
ed16fb4
to
df1849f
Compare
Started Vanilla file pre-checkin pipeline... Build Number: 566 |
Started Vanilla file pre-checkin pipeline... Build Number: 567 |
Started Vanilla file pre-checkin pipeline... Build Number: 568 |
Started Vanilla file pre-checkin pipeline... Build Number: 569 |
Started Vanilla file pre-checkin pipeline... Build Number: 570 |
Started Vanilla file pre-checkin pipeline... Build Number: 571 |
Started Vanilla file pre-checkin pipeline... Build Number: 572 |
Started Vanilla file pre-checkin pipeline... Build Number: 575 |
Started Vanilla file pre-checkin pipeline... Build Number: 576 |
df1849f
to
d9d8ff9
Compare
|
Started Vanilla file pre-checkin pipeline... Build Number: 577 |
21cff36
to
6212df9
Compare
|
6212df9
to
ad61a87
Compare
Started Vanilla file pre-checkin pipeline... Build Number: 578 |
ad61a87
to
4581050
Compare
|
4581050
to
2f2798d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rpanduranga The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fix deprecated storage class annotations
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.
Special notes for your reviewer:
Release note: