Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated storage class annotations #2385

Conversation

rpanduranga
Copy link
Contributor

What this PR does / why we need it:
Fix deprecated storage class annotations

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rpanduranga. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2023
@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from 85765a6 to 88197dc Compare May 17, 2023 15:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from 88197dc to e4a6f5a Compare May 17, 2023 16:04
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2023
@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch 3 times, most recently from ed16fb4 to df1849f Compare May 18, 2023 19:45
@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 566

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 567

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 568

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 569

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 570

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 571

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 572

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 575

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 576

@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from df1849f to d9d8ff9 Compare May 19, 2023 07:37
@svcbot-qecnsdp
Copy link

Build ID: 576
File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 736 Skipped
--- FAIL: TestE2E (661.42s)
FAIL

Ginkgo ran 1 suite in 12m4.207126631s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-file-vanilla-pre-check-in/576/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 577

@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch 2 times, most recently from 21cff36 to 6212df9 Compare May 19, 2023 07:55
@svcbot-qecnsdp
Copy link

Build ID: 577
File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 736 Skipped
--- FAIL: TestE2E (656.42s)
FAIL

Ginkgo ran 1 suite in 12m2.494010505s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-file-vanilla-pre-check-in/577/vsphere-csi-driver`

@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from 6212df9 to ad61a87 Compare May 19, 2023 08:00
@svcbot-qecnsdp
Copy link

Started Vanilla file pre-checkin pipeline... Build Number: 578

@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from ad61a87 to 4581050 Compare May 19, 2023 08:09
@svcbot-qecnsdp
Copy link

Build ID: 578
File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 737 Skipped
--- FAIL: TestE2E (928.68s)
FAIL

Ginkgo ran 1 suite in 16m41.188444798s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-file-vanilla-pre-check-in/578/vsphere-csi-driver`

@rpanduranga rpanduranga force-pushed the replace-deprecated-annotations branch from 4581050 to 2f2798d Compare May 23, 2023 16:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rpanduranga
Once this PR has been reviewed and has the lgtm label, please assign sashrith for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants