Determine cluster distribution server version & type using kubernetes API server version #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
chethanv28
force-pushed
the
telemetry-improvements
branch
from
a83b981
to
04eb779
Compare
chethanv28
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chethanv28
force-pushed
the
telemetry-improvements
branch
3 times, most recently
from
04bbe75
to
8589611
Compare
|
Started Vanilla block pre-checkin pipeline... Build Number: 2198 |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
divyenpatel
requested changes
Jun 9, 2023
chethanv28
force-pushed
the
telemetry-improvements
branch
from
b9152ea
to
58433be
Compare
|
Started Vanilla block pre-checkin pipeline... Build Number: 2201 |
|
divyenpatel
reviewed
Jun 12, 2023
chethanv28
force-pushed
the
telemetry-improvements
branch
from
58433be
to
9e5d4c2
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rajguptavm
pushed a commit
to rajguptavm/vsphere-csi-driver
that referenced
this pull request
Jul 20, 2023
… API server version (kubernetes-sigs#2404) * Determine cluster distribution server version & type using kubernetes API server version * Exit the container if we are not able to fetch the k8s client * break the loop as soon as we find the distribution type
chethanv28
added a commit
to chethanv28/vsphere-csi-driver
that referenced
this pull request
Sep 20, 2023
… API server version (kubernetes-sigs#2404) * Determine cluster distribution server version & type using kubernetes API server version * Exit the container if we are not able to fetch the k8s client * break the loop as soon as we find the distribution type
chethanv28
added a commit
to chethanv28/vsphere-csi-driver
that referenced
this pull request
Sep 20, 2023
… API server version (kubernetes-sigs#2404) * Determine cluster distribution server version & type using kubernetes API server version * Exit the container if we are not able to fetch the k8s client * break the loop as soon as we find the distribution type
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 26, 2023
… during attach/detach. (#2573) * Determine cluster distribution server version & type using kubernetes API server version (#2404) * Determine cluster distribution server version & type using kubernetes API server version * Exit the container if we are not able to fetch the k8s client * break the loop as soon as we find the distribution type * skip adding node to cache during attach or detach operation (#2546) --------- Co-authored-by: Divyen Patel <divyenp@vmware.com>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 26, 2023
…related to AttachVolumes and also the nodes cache fix during attach/detach. (#2561) * Determine cluster distribution server version & type using kubernetes API server version (#2404) * Determine cluster distribution server version & type using kubernetes API server version * Exit the container if we are not able to fetch the k8s client * break the loop as soon as we find the distribution type * skip adding node to cache during attach or detach operation (#2546) * Return volume path as part of ListVolumes response for migrated volumes (#2558) --------- Co-authored-by: Divyen Patel <divyenp@vmware.com> Co-authored-by: Aditya Kulkarni <adkulkarni@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is attempting to set cluster distribution type based on the k8s API server version by fetching it from the k8s cluster.
This PR is still in-works. Please do not review.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Here is a cluster with the cluster-distribution field set to empty string:
With the changes from this PR, the cluster distribution is set dynamically to Vanillak8s as the API server version is empty
Special notes for your reviewer:
Release note: