Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSI 2.6.x] Cross-port telemetry enhancements and the nodes cache fix during attach/detach #2616

Merged

Conversation

chethanv28
Copy link
Collaborator

@chethanv28 chethanv28 commented Oct 25, 2023

What this PR does / why we need it:
Cross-port telemetry enhancements, CSI Migration bug fix related to AttachVolumes and also the nodes cache fix during attach/detach.

The below pull requests are cherry-picked as part of this PR:
#2546
#2404

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

kubectl get pods -n vmware-system-csi -o wide 
NAME                                      READY   STATUS    RESTARTS   AGE   IP              NODE                         NOMINATED NODE   READINESS GATES
vsphere-csi-controller-7768f66499-dw5q9   7/7     Running   0          38m   10.244.2.5      k8s-control-282-1698699174   <none>           <none>
vsphere-csi-node-79r7w                    3/3     Running   0          34m   10.193.44.166   k8s-node-188-1698699204      <none>           <none>
vsphere-csi-node-8p9nk                    3/3     Running   0          36m   10.193.35.249   k8s-control-385-1698699161   <none>           <none>
vsphere-csi-node-bhxpd                    3/3     Running   0          35m   10.193.33.248   k8s-node-223-1698699216      <none>           <none>
vsphere-csi-node-c9v8c                    3/3     Running   0          35m   10.193.54.14    k8s-control-282-1698699174   <none>           <none>
vsphere-csi-node-hmqpr                    3/3     Running   0          37m   10.193.62.253   k8s-control-269-1698699149   <none>           <none>
vsphere-csi-node-xlsh4                    3/3     Running   0          36m   10.193.55.254   k8s-node-439-1698699188      <none>           <none>

kubectl get sc,pvc -A
NAME                                                            PROVISIONER              RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
storageclass.storage.k8s.io/example-vanilla-rwo-filesystem-sc   csi.vsphere.vmware.com   Delete          Immediate           true                   5m

NAMESPACE   NAME                                            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                        AGE
default     persistentvolumeclaim/example-vanilla-rwo-pvc   Bound    pvc-d4cf7654-8w4d-4487-8c3e-66ef47eb4113   1Gi        RWO            example-vanilla-rwo-filesystem-sc   2m

Special notes for your reviewer:

Release note:

Cross-port telemetry enhancements and nodes cache fix during attach/detach.

chethanv28 and others added 2 commits October 25, 2023 15:47
…es API server version

* Exit the container if we are not able to fetch the k8s client

* break the loop as soon as we find the distribution type

* skip adding node to cache during attach or detach operation

---------

Co-authored-by: Divyen Patel <divyenp@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2023
@chethanv28
Copy link
Collaborator Author

/test pull-vsphere-csi-driver-verify-staticcheck

@divyenpatel
Copy link
Member

/approve

@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 2520

Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ad2efdf into kubernetes-sigs:release-2.6 Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants