-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume stats support #30
Conversation
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
Welcome @zuzzas! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zuzzas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @zuzzas. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @zuzzas. Thank you for this PR! I have a couple different types of feedback for you...
I see your point, and I had similar issues with This specific driver is about to get a fully new implementation by the VMware Business Unit responsible for Storage. This will be a much more fully-featured driver, suitable for production workloads, and fully supported. This is a reason why this driver has remained in alpha state. It is not intended for this current implementation to live on once the new one is available, and I believe we will see the new one within the next week or two. Once that becomes available, it may very well be the case that it could use an implementation for |
Thanks for the quick response. We'll wait for it, then. And, perhaps, find ways to collaborate on the next implementation. |
Bug 2031045: Update to upstream v2.4.1
Bug 2029835: Revert "Merge pull request kubernetes-sigs#30 from bertinatto/rebase-v2.4.1"
What this PR does / why we need it:
Support NodeGetVolumeStats CSI call.
gRPC error problem
![image](https://user-images.githubusercontent.com/950313/61618903-83458300-ac76-11e9-9914-838b181d4d22.png)
There is one problem that I haven't tackled. How do I verify that some fs path corresponds to volume ID without something similar to PublishContext?