fix: overwrite --service-account-issuer #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ernest Wong chuwon@microsoft.com
Attempts to fix the following test case
in https://testgrid.k8s.io/sig-release-master-informing#aks-engine-azure-windows-master-containerd.
Looks like we need to prepend
https://
for--service-account-issuer
but aks-engine doesn't do that currently (https://github.com/Azure/aks-engine/blob/master/pkg/api/defaults-apiserver.go#L104). If this fixes the test failure, I will open a PR against aks-engine.