-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PPC64LE arch #39
Conversation
-race is not supported for PPC
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ezeeyahoo! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ezeeyahoo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.travis.yml
Outdated
@@ -7,7 +11,8 @@ script: | |||
- diff -u <(echo -n) <(gofmt -d *.go) | |||
- diff -u <(echo -n) <(golint $(go list -e ./...) | grep -v YAMLToJSON) | |||
- GO111MODULE=on go vet . | |||
- GO111MODULE=on go test -v -race ./... | |||
# race is not supported for ppc64le | |||
- if [[ "$TRAVIS_CPU_ARCH" != "ppc64le" ]]; then GO111MODULE=on go test -v -race ./...; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you want to run the tests? (without the race)
@ezeeyahoo please file the CLA, this definitely does not look ready |
Hi,
I have added support for PPC64LE, please review.
Thanks