Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go pins a version of gopkg.in/yaml.v2 from 2 years ago #325

Closed
danderson opened this issue Nov 12, 2017 · 4 comments
Closed

client-go pins a version of gopkg.in/yaml.v2 from 2 years ago #325

danderson opened this issue Nov 12, 2017 · 4 comments
Assignees
Labels

Comments

@danderson
Copy link

@danderson danderson commented Nov 12, 2017

The Godeps.json for client-go pins gopkg.in/yaml.v2 to version 53feefa2559fb8dfa8d81baad31be332c97d6c77 . That commit is from 2 years ago, and lacks a lot of bug fixes and new functionality (notably UnmarshalStrict, which is extremely useful for parsing configs out of ConfigMaps).

Please update this package pin to a (much) newer version.

More generally, this is a worrying consequence of using package locks without actively updating them over time. How many CVEs am I vulnerable to because client-go is forcing my code to pull in ancient libraries? Are there any plans to try and address this?

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Feb 10, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@sttts
Copy link
Contributor

@sttts sttts commented Feb 12, 2018

@danderson is this still a problem? Feel free to submit a PR.

/remove-lifecycle stale

@anubhakushwaha
Copy link
Contributor

@anubhakushwaha anubhakushwaha commented Feb 16, 2018

@sttts @nikhita Wasn't this updated here due to this PR, let me know if I misunderstood something.

@nikhita
Copy link
Member

@nikhita nikhita commented Feb 16, 2018

@anubhakushwaha That's right. 👍

The current version is at 670d4cfef0544295bc27a114dbac37980d83185a, which is from July 2017.

Closing.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants