-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable node registration when UUID is empty #522
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nicolehanjing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You can just error out here if vmDI has empty UUID
Also could you update the log here
It's still referencing the oVM.Summary.Config.Uuid to get the uuid, it will help debugging.
|
70a580d
to
d118330
Compare
d118330
to
0fce88e
Compare
/lgtm |
What this PR does / why we need it:
CPI generates providerID by combining "provider_name + system UUID" e.g. "vsphere://UUID", but the system UUID we fetched from vCenter (via govmomi) is empty. So the final providerID we get is "vsphere://", which is invalid.
In such case, we should disable node registration when UUID is empty
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #521Special notes for your reviewer:
Release note: