Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable node registration when UUID is empty #522

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

nicolehanjing
Copy link
Member

What this PR does / why we need it:
CPI generates providerID by combining "provider_name + system UUID" e.g. "vsphere://UUID", but the system UUID we fetched from vCenter (via govmomi) is empty. So the final providerID we get is "vsphere://", which is invalid.
In such case, we should disable node registration when UUID is empty

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #521

Special notes for your reviewer:

Release note:

disable node registration when UUID is empty

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicolehanjing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2021
@nicolehanjing
Copy link
Member Author

cc @dougm @lubronzhan

@nicolehanjing nicolehanjing changed the title [WIP] disable node registration when UUID is empty disable node registration when UUID is empty Nov 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2021
@lubronzhan
Copy link
Contributor

lubronzhan commented Nov 5, 2021

You can just error out here if vmDI has empty UUID

vmDI, err := nm.shakeOutNodeIDLookup(ctx, nodeID, searchBy)

Also could you update the log here

klog.V(2).Info("Hostname: ", oVM.Guest.HostName, " UUID: ", oVM.Summary.Config.Uuid)

It's still referencing the oVM.Summary.Config.Uuid to get the uuid, it will help debugging.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2021
@lubronzhan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1bce29c into master Nov 8, 2021
@lubronzhan lubronzhan deleted the nicoleh-fix-providerid branch October 19, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPI is not adding proper 'ProviderID:' on the node with UUID
3 participants