Skip to content

Commit

Permalink
Merge pull request #908 from ianchakeres/fix-auth-link
Browse files Browse the repository at this point in the history
Fixed link to auth_test.go in coding-conventions.md
  • Loading branch information
cblecker committed Aug 15, 2017
2 parents 4d80144 + 6227521 commit 2754ac1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion contributors/devel/coding-conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ following Go conventions - `stateLock`, `mapLock` etc.
tests

- Table-driven tests are preferred for testing multiple scenarios/inputs; for
example, see [TestNamespaceAuthorization](../../test/integration/auth/auth_test.go)
example, see [TestNamespaceAuthorization](https://git.k8s.io/kubernetes/test/integration/auth/auth_test.go)

- Significant features should come with integration (test/integration) and/or
[end-to-end (test/e2e) tests](e2e-tests.md)
Expand Down
4 changes: 2 additions & 2 deletions contributors/devel/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ passing, so it is often a good idea to make sure the e2e tests work as well.
* All packages and any significant files require unit tests.
* The preferred method of testing multiple scenarios or input is
[table driven testing](https://github.com/golang/go/wiki/TableDrivenTests)
- Example: [TestNamespaceAuthorization](https://github.com/kubernetes/kubernetes/blob/master/test/integration/auth/auth_test.go)
- Example: [TestNamespaceAuthorization](https://git.k8s.io/kubernetes/test/integration/auth/auth_test.go)
* Unit tests must pass on OS X and Windows platforms.
- Tests using linux-specific features must be skipped or compiled out.
- Skipped is better, compiled out is required when it won't compile.
Expand Down Expand Up @@ -161,7 +161,7 @@ See `go help test` and `go help testflag` for additional info.
- This includes kubectl commands
* The preferred method of testing multiple scenarios or inputs
is [table driven testing](https://github.com/golang/go/wiki/TableDrivenTests)
- Example: [TestNamespaceAuthorization](https://github.com/kubernetes/kubernetes/blob/master/test/integration/auth/auth_test.go)
- Example: [TestNamespaceAuthorization](https://git.k8s.io/kubernetes/test/integration/auth/auth_test.go)
* Each test should create its own master, httpserver and config.
- Example: [TestPodUpdateActiveDeadlineSeconds](https://github.com/kubernetes/kubernetes/blob/master/test/integration/pods/pods_test.go)
* See [coding conventions](coding-conventions.md).
Expand Down

0 comments on commit 2754ac1

Please sign in to comment.