-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please create repositories for component config types for - controller-manager/proxy/scheduler/kubelet #2627
Comments
cc @luxas @dixudx @Lion-Wei @stewart-yu @bsalamat @derekwaynecarr @dchen1107 @k82cn @thockin @dcbw @caseydavenport Folks, please +1 the request @kubernetes/sig-node-pr-reviews @kubernetes/sig-network-pr-reviews @kubernetes/sig-scheduling-pr-reviews |
@dims kube-controller-manager is missing. |
Added. thanks @sttts |
@dims also please compare the required permissions documented in kubernetes/org#56. Also note that this was already approved by sig-arch through KEP 14. |
For the publishing bot please create a PR like kubernetes/publishing-bot#93. |
@spiffxp with csi-api I saw you copied some repo template. Can we have another repo template just for staging repos? They should not have any files and the permissions are special, compare kubernetes/org#56. |
@sttts are you asking for a completely blank repo, or do you need these to be empty repos with an initial commit? what will give me confidence is if I can see valid copies of those files in the staging repo that's going to sync to them, and get cc'ed on something that tracks the first sync happening (issue, pr, whatever) @dims the actual requests for these repos should be made against kubernetes/org FWIW |
@spiffxp a first empty commit if possible. The new repos are all in https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io and have those default files. |
This is now done, thanks everyone 🎉 !! |
/close |
@luxas: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In the following PR(s), we added new directories under staging/src/k8s.io/ for holding component config api types
k8s.io/kubelet
kubernetes#67263k8s.io/kube-proxy
kubernetes#67688k8s.io/kube-controller-manager
kubernetes#67469More specifically we need 4 new repositories to hold them:
And we need to update the bot that sync(s) the directories to the corresponding repos as well
The text was updated successfully, but these errors were encountered: