Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create repositories for component config types for - controller-manager/proxy/scheduler/kubelet #2627

Closed
dims opened this issue Sep 4, 2018 · 11 comments
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@dims
Copy link
Member

dims commented Sep 4, 2018

In the following PR(s), we added new directories under staging/src/k8s.io/ for holding component config api types

More specifically we need 4 new repositories to hold them:

And we need to update the bot that sync(s) the directories to the corresponding repos as well

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 4, 2018
@dims
Copy link
Member Author

dims commented Sep 4, 2018

cc @luxas @dixudx @Lion-Wei @stewart-yu @bsalamat @derekwaynecarr @dchen1107 @k82cn @thockin @dcbw @caseydavenport Folks, please +1 the request

@kubernetes/sig-node-pr-reviews @kubernetes/sig-network-pr-reviews @kubernetes/sig-scheduling-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2018
@jdumars jdumars added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Sep 4, 2018
@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

@dims kube-controller-manager is missing.

@dims
Copy link
Member Author

dims commented Sep 4, 2018

Added. thanks @sttts

@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

@dims also please compare the required permissions documented in kubernetes/org#56.

Also note that this was already approved by sig-arch through KEP 14.

@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

For the publishing bot please create a PR like kubernetes/publishing-bot#93.

@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

@spiffxp with csi-api I saw you copied some repo template. Can we have another repo template just for staging repos? They should not have any files and the permissions are special, compare kubernetes/org#56.

@spiffxp
Copy link
Member

spiffxp commented Sep 4, 2018

@sttts are you asking for a completely blank repo, or do you need these to be empty repos with an initial commit? what will give me confidence is if I can see valid copies of those files in the staging repo that's going to sync to them, and get cc'ed on something that tracks the first sync happening (issue, pr, whatever)

@dims the actual requests for these repos should be made against kubernetes/org FWIW

@sttts
Copy link
Contributor

sttts commented Sep 5, 2018

are you asking for a completely blank repo, or do you need these to be empty repos with an initial commit?

@spiffxp a first empty commit if possible.

The new repos are all in https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io and have those default files.

@luxas
Copy link
Member

luxas commented Sep 12, 2018

This is now done, thanks everyone 🎉 !!

@luxas
Copy link
Member

luxas commented Sep 12, 2018

/close

@k8s-ci-robot
Copy link
Contributor

@luxas: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

6 participants