[RFC] SIG-Node initial charter #2065

derekwaynecarr · 2018-04-23T21:42:04Z

Co-authored by: @derekwaynecarr @dchen1107

/sig node

Topics for discussion with @kubernetes/steering-committee review:

working group lifecycle - this proposal empowers a technical lead of a sig to sponsor a working group. if working groups span sigs, this would mean agreement from a technical lead from each sponsoring sig may be required, and therefore should be common across the project.
process to decommission a sub-project - could be a variety of reasons (not healthy, not maintained, no longer endorsed or accepted by the sig). this proposal makes no statement on the mechanism other than stating technical leads should have the power.

resouer · 2018-04-24T05:47:59Z

sig-node/governance.md

+  - Number: 1-3
+  - Defined in [sigs.yaml]
+
+- **Technical Leads**


TL have overlap with Chairs, is it expected?

yes, it is expected. the traditional sig lead role has been split into chair and technical lead roles. for sig-node, i anticipate there will be overlap where chairs will also serve as technical leads, but we may want to expand the list of tech leads to at least have an odd number.

derekwaynecarr · 2018-04-30T15:17:18Z

Added section for scope per guidelines enumerated in #2078

/cc @dchen1107 PTAL

k8s-ci-robot · 2018-04-30T15:17:20Z

@derekwaynecarr: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Added section for scope per guidelines enumerated in #2078

/cc @dchen1107 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pwittrock · 2018-06-28T19:22:41Z

sig-node/README.md


 * Kubelet related features (e.g. Pod lifecycle)
 * Node level performance and scalability (with [sig-scalability](../sig-scalability))
-* Node reliability
+* Node reliability (prooblem detection and remediation)


timothysc · 2018-06-29T00:12:48Z

sig-node/charter.md

+
+#### Subproject creation
+
+- Subprojects *MAY* be created by [KEP] proposal and *MUST* be approved by at


This seems like it should be generalized policy. I don't know if it belongs here.

philips · 2018-07-03T22:57:37Z

sig-node/charter.md

+* Node lifecycle management (with [sig-cluster-lifecycle](../sig-cluster-lifecycle))
+* Container runtimes
+* Device management
+* Images, package management


I think I know what you mean by package management but it might be confused with SIG release

philips · 2018-07-03T23:00:25Z

sig-node/charter.md

+
+The following topics are out of the scope of this SIG
+
+* network management


can you expand on this? Or perhaps link to sig-network?

philips · 2018-07-03T23:00:37Z

sig-node/charter.md

+The following topics are out of the scope of this SIG
+
+* network management
+* persistent storage management


link to sig storage?

philips · 2018-07-20T16:49:22Z

Thank you for your patience as we work to your SIG charter merged.

Through the process of reviewing the first 11 charters the Steering Committee (SC) found a lot of copy/paste language caused by our poorly designed initial charter template. To fix this there is a new SIG charter template which focuses on the main things we want to see in charters: scope and responsibilities.

Please consider updating to this charter template and putting focus into the scope and responsibilities. SC members will focus more on a deep review of scope more than anything else and using this template will help with that focus.

derekwaynecarr · 2018-08-01T14:10:48Z

@dchen1107 updated to opt-in to default sig-governance which did not differ significantly.

@philips this should be ready for final review.

bgrant0607 · 2018-08-07T02:31:04Z

sig-node/charter.md

+- Container runtimes
+- Device management
+- Image management
+- Host resource management (with [sig-scheduling](../sig-scheduling))


I suggest calling this "node-level", for consistency with the other bullets

bgrant0607 · 2018-08-07T02:32:46Z

sig-node/charter.md

+
+#### Code, Binaries and Services
+
+- Kubelet related features (e.g. Pod lifecycle)


The template says: list of what qualifies a piece of code, binary or service as falling into the scope of this SIG

So how about: Kubelet and its features

What about:

The Pod API and Pod behaviors (some fields are owned by other SIGs, but...)

The Node API

Node controller
?

bgrant0607 · 2018-08-07T02:44:21Z

sig-node/charter.md

+Pick one:
+
+1. SIG Technical Leads (x)
+2. Federation of Subprojects


Please remove the second bullet if you're opting for the first

bgrant0607 · 2018-08-07T02:53:18Z

sig-node/charter.md

+SIG Node is responsible for the components that support the controlled
+interactions between pods and host resources.  We manage the lifecycle of pods
+that are scheduled to a node.  We focus on enabling a broad set of workload
+types, including hardware and performance sensitive workloads.  We maintain


I have trouble parsing "including hardware and performance sensitive workloads".

bgrant0607 · 2018-08-07T02:55:26Z

sig-node/charter.md

+
+### In scope
+
+Link to SIG section in [sigs.yaml]


I think you're supposed to insert a link, though linking to the generated README seems easier.

bgrant0607 · 2018-08-24T02:40:36Z

Thank you for the updates.

/lgtm
/approve

k8s-ci-robot · 2018-08-24T02:40:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sig-node/OWNERS~~ [bgrant0607]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2018

k8s-ci-robot requested review from calebamiles and dchen1107 April 23, 2018 21:42

derekwaynecarr force-pushed the sig-node-charter branch from 2f95009 to 220ad17 Compare April 23, 2018 21:45

resouer reviewed Apr 24, 2018

View reviewed changes

derekwaynecarr force-pushed the sig-node-charter branch from 220ad17 to 371c365 Compare April 30, 2018 15:15

pwittrock added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Jun 21, 2018

jdumars mentioned this pull request Jun 24, 2018

Charters Meta-issue kubernetes/steering#31

Closed

pwittrock reviewed Jun 28, 2018

View reviewed changes

timothysc reviewed Jun 29, 2018

View reviewed changes

philips reviewed Jul 3, 2018

View reviewed changes

derekwaynecarr force-pushed the sig-node-charter branch from 371c365 to b8941fb Compare August 1, 2018 14:05

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2018

derekwaynecarr force-pushed the sig-node-charter branch from b8941fb to 574e0bb Compare August 1, 2018 14:08

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2018

bgrant0607 reviewed Aug 7, 2018

View reviewed changes

derekwaynecarr added 2 commits August 23, 2018 14:10

[RFC] SIG-Node initial charter

b0f0905

update per common charter template

1efc194

derekwaynecarr force-pushed the sig-node-charter branch from 574e0bb to 1efc194 Compare August 23, 2018 18:28

k8s-ci-robot assigned bgrant0607 Aug 24, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018

k8s-ci-robot merged commit e340fb5 into kubernetes:master Aug 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] SIG-Node initial charter #2065

[RFC] SIG-Node initial charter #2065

derekwaynecarr commented Apr 23, 2018

resouer Apr 24, 2018 •

edited

derekwaynecarr Apr 24, 2018

derekwaynecarr commented Apr 30, 2018

k8s-ci-robot commented Apr 30, 2018

pwittrock Jun 28, 2018

timothysc Jun 29, 2018

philips Jul 3, 2018

philips Jul 3, 2018

philips Jul 3, 2018

philips commented Jul 20, 2018

derekwaynecarr commented Aug 1, 2018

bgrant0607 Aug 7, 2018

bgrant0607 Aug 7, 2018

bgrant0607 Aug 7, 2018

bgrant0607 Aug 7, 2018

bgrant0607 Aug 7, 2018

bgrant0607 Aug 7, 2018

bgrant0607 commented Aug 24, 2018

k8s-ci-robot commented Aug 24, 2018


		#### Subproject creation

		- Subprojects MAY be created by [KEP] proposal and MUST be approved by at


		The following topics are out of the scope of this SIG

		* network management


		#### Code, Binaries and Services

		- Kubelet related features (e.g. Pod lifecycle)

[RFC] SIG-Node initial charter #2065

[RFC] SIG-Node initial charter #2065

Conversation

derekwaynecarr commented Apr 23, 2018

resouer Apr 24, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr commented Apr 30, 2018

k8s-ci-robot commented Apr 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philips commented Jul 20, 2018

derekwaynecarr commented Aug 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgrant0607 commented Aug 24, 2018

k8s-ci-robot commented Aug 24, 2018

resouer Apr 24, 2018 •

edited