[WIP] Create cloning.md #2533

erinboyd · 2018-08-14T13:21:38Z

Design proposal for same namespace cloning support in kube

k8s-ci-robot · 2018-08-14T13:21:45Z

Hi @erinboyd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-08-14T13:21:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: childsb

If they are not already assigned, you can assign the PR to them by writing /assign @childsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

contributors/design-proposals/storage/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

j-griffith

Looks good for the most part, some minor wording and a typo (I never spot those) in the intro paragraph.

I did have some other thoughts/questions in line as well, thanks for putting this together!

j-griffith · 2018-08-14T15:28:08Z

contributors/design-proposals/storage/cloning.md

@@ -44,6 +44,105 @@ Specific use cases around cloning are included in the use cases listed below as
 ## Design Overview
 The proposed design is based on the idea of leveraging well defined concepts for storage in Kubernetes. The cloning will be initiated 
 by creating an annotated PVC to create a new volume using a defined storage class that supports cloning.
-The actual cloning process must be implemented by the provisioning storage and properly understand and react to the annotation to clone.
+The actual cloning process must be implemented by the provisioning storage and properly understand and react to the annotation to clone. In the absence of a storage class that supports cloning a host-assisted clone can also be exected to create the copy. The host-assisted cloning deploys a controller to utlize pod streaming to execute the copy.


s/and properly understand and react/, therefore plugins that support cloning need to ensure they're checking ..../

Also, do we want annotations mentioned here or aren't we using VolumeContentSource from the spec?

minor typo s/exected/executed/

j-griffith · 2018-08-14T15:33:50Z

contributors/design-proposals/storage/cloning.md

+  accessModes:
+    - ReadWriteOnce
+  storageClassName: csi-gce-pd
+  dataSource:


Ahh, yeah that's what I was getting at above; I'd just call out the field name rather than say "annotations" just to be clear.

j-griffith · 2018-08-14T15:36:19Z

contributors/design-proposals/storage/cloning.md

+  name: csi-gce-pd
+provisioner: kubernetes.io/gce-pd
+parameters:
+  smartclone: "true"


Should smartclone just be an inherent/implied thin based on the a devices reported capabilities? In other words if it's reported via capabilities a user doesn't need to specify this; a clone request is made, if capabilities allow great, if not error or fall back to host-assisted if possible.

I think this will change with the introduction of the populator, which I have intentionally left out of this proposal. I can remove this as well so as to reduce confusion

erinboyd · 2018-08-21T00:03:21Z

@j-griffith please re-review to make sure I didn't miss anything from the design meeting. Thanks!

humblec · 2018-10-10T10:59:28Z

contributors/design-proposals/storage/cloning.md

+    storage: 100Gi
+  volumeMode: Filesystem
+accessModes:
+    - ReadOnlyMany


@erinboyd @aglitke Do we need to think about restricting a clone for a RO source PV?

@humblec I believe that came up in some discussions, but most devices that offer enhanced cloning features also handle things like dealing with consistency internally. Even for those doing host assisted type cloning they would implicitly deal with this as well if they need to via mount options. Also, just to be clear this is referencing the PVC and not the PV (just to make sure there's no confusion).

We don't want to restrict the cloning operation to RO I don't think, if we need something to control in-use PVCs we could perhaps use capabilities reporting (CSI Plugin/Spec) and deal with it there. So something like "can clone in-use volumes" or something like that?

j-griffith · 2018-11-02T20:51:04Z

contributors/design-proposals/storage/cloning.md

+// Specifies what source the volume will be created from. One of the
+// type fields MUST be specified.
+message VolumeContentSource {
+  message SnapshotSource {


We've got this one in place so that's good

j-griffith · 2018-11-02T20:51:53Z

contributors/design-proposals/storage/cloning.md

+    // CREATE_DELETE_SNAPSHOT.
+    string id = 1;
+  }
+  message PersistentVolumeSource {


This ones under review, uses a more generic term of "VolumeSource" which I think is preferable.
container-storage-interface/spec#244

fejta-bot · 2019-01-31T21:02:45Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2019-01-31T21:02:52Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2019-03-02T21:20:02Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2019-04-01T22:07:07Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2019-04-01T22:07:15Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Create cloning.md

1fcc960

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Aug 14, 2018

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2018

k8s-ci-robot requested review from childsb and saad-ali August 14, 2018 13:21

erinboyd changed the title ~~Create cloning.md~~ [WIP] Create cloning.md Aug 14, 2018

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2018

Update cloning.md

14517cd

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2018

Update cloning.md

9570124

j-griffith reviewed Aug 14, 2018

View reviewed changes

Erin A Boyd added 3 commits August 14, 2018 09:43

Update cloning.md

1439704

Update cloning.md

e2fa1ce

Update cloning.md

f5e64e8

Erin A Boyd added 2 commits August 21, 2018 07:40

Update cloning.md

8966384

Update cloning.md

8366d47

xing-yang mentioned this pull request Aug 23, 2018

Add data source for volume provisioning #2495

Merged

humblec reviewed Oct 10, 2018

View reviewed changes

j-griffith reviewed Nov 2, 2018

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2019

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2019

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 31, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 2, 2019

k8s-ci-robot closed this Apr 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Create cloning.md #2533

[WIP] Create cloning.md #2533

erinboyd commented Aug 14, 2018 •

edited

Loading

k8s-ci-robot commented Aug 14, 2018

k8s-ci-robot commented Aug 14, 2018

j-griffith left a comment

j-griffith Aug 14, 2018

j-griffith Aug 14, 2018

j-griffith Aug 14, 2018

erinboyd Aug 17, 2018

erinboyd commented Aug 21, 2018

humblec Oct 10, 2018 •

edited

Loading

j-griffith Nov 2, 2018

j-griffith Nov 2, 2018

j-griffith Nov 2, 2018

fejta-bot commented Jan 31, 2019

k8s-ci-robot commented Jan 31, 2019

fejta-bot commented Mar 2, 2019

fejta-bot commented Apr 1, 2019

k8s-ci-robot commented Apr 1, 2019

[WIP] Create cloning.md #2533

[WIP] Create cloning.md #2533

Conversation

erinboyd commented Aug 14, 2018 • edited Loading

k8s-ci-robot commented Aug 14, 2018

k8s-ci-robot commented Aug 14, 2018

j-griffith left a comment

Choose a reason for hiding this comment

j-griffith Aug 14, 2018

Choose a reason for hiding this comment

j-griffith Aug 14, 2018

Choose a reason for hiding this comment

j-griffith Aug 14, 2018

Choose a reason for hiding this comment

erinboyd Aug 17, 2018

Choose a reason for hiding this comment

erinboyd commented Aug 21, 2018

humblec Oct 10, 2018 • edited Loading

Choose a reason for hiding this comment

j-griffith Nov 2, 2018

Choose a reason for hiding this comment

j-griffith Nov 2, 2018

Choose a reason for hiding this comment

j-griffith Nov 2, 2018

Choose a reason for hiding this comment

fejta-bot commented Jan 31, 2019

k8s-ci-robot commented Jan 31, 2019

fejta-bot commented Mar 2, 2019

fejta-bot commented Apr 1, 2019

k8s-ci-robot commented Apr 1, 2019

erinboyd commented Aug 14, 2018 •

edited

Loading

humblec Oct 10, 2018 •

edited

Loading