Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow on working group gov #2814

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Follow on working group gov #2814

merged 2 commits into from
Nov 19, 2018

Conversation

pwittrock
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Oct 16, 2018
@pwittrock pwittrock mentioned this pull request Oct 16, 2018
Merged
@idvoretskyi
Copy link
Member

cc @jdumars

@pwittrock
Copy link
Member Author

cc @kubernetes/steering-committee

@jdumars
Copy link
Member

jdumars commented Oct 17, 2018

One nit: "do not own code" should be "do not own code inside kubernetes/kubernetes or other core repositories"

I think that addresses some of the concerns from the prior PR.

Thank you for getting this wrapped up!

@jdumars
Copy link
Member

jdumars commented Oct 17, 2018

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2018
@michelleN
Copy link

/lgtm

spiffxp
spiffxp reviewed Oct 17, 2018
View reviewed changes
committee-steering/governance/wg-governance.md Outdated
@@ -62,8 +60,7 @@ requirements for that are:
- chair information
- meeting information
- contact methods
- any sig stakeholders
- any subproject stakeholders
- any [sig or subproject](sig-governance.md#project-management) stakeholders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dare I ask why sig or subproject? asking from a perspective of wanting to update sigs.yaml to have working groups specify which entities they interface with

I had assumed it was just going to be a sigs: field, now I'm guessing it would look like sigs: and subprojects: fields and wondering why the additional complexity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ref #2176)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL. I removed the line about projects.

spiffxp
spiffxp reviewed Oct 17, 2018
View reviewed changes
committee-steering/governance/wg-governance.md Outdated
@@ -92,7 +89,7 @@ Working Groups will be disbanded if either of the following is true:
- Zoom

The current Chair may step down at any time. When they do so, a new Chair may be selected through lazy consensus
within the Working Group.
within the Working Group, and [sigs.yaml](../../sigs.yaml) should be updated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown nit: (/sigs.yaml)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@spiffxp spiffxp mentioned this pull request Oct 18, 2018
Closed
philips
philips suggested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@philips philips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall /lgtm

committee-steering/governance/wg-governance.md Outdated
@@ -62,8 +60,7 @@ requirements for that are:
- chair information
- meeting information
- contact methods
- any sig stakeholders
- any subproject stakeholders
- any [sig or subproject](sig-governance.md#project-management) stakeholders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this question

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@pwittrock
Copy link
Member Author

@spiffxp @philips PTAL

I added a section clarifying the relationship between WGs and SIGs

@jdumars
Copy link
Member

jdumars commented Nov 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
idvoretskyi
idvoretskyi approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michelleN
Copy link

/lgtm

@jbeda
Copy link
Contributor

jbeda commented Nov 15, 2018

/lgtm

Ship it! We should aim to have tweaks/refactors like this merge quickly.

@philips
Copy link
Contributor

philips commented Nov 19, 2018

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 346b0da into kubernetes:master Nov 19, 2018
@nikhita nikhita mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@philips philips philips requested changes

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@philips philips

@jbeda jbeda

@idvoretskyi idvoretskyi

@jdumars jdumars

@michelleN michelleN

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pwittrock @idvoretskyi @jdumars @michelleN @jbeda @philips @k8s-ci-robot @spiffxp