Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-config: Add Jeremy Rickard as a SIG Release Technical Lead #5407

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

hasheddan
Copy link
Contributor

Adds @jeremyrickard to sig-release slack groups as part of technical lead
onboarding.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Which issue(s) this PR fixes:

xref kubernetes/sig-release#1421

/hold
/assign @justaugustus @saschagrunert

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan -- Roughly the same review ashttps://github.com/kubernetes/k8s.io/pull/1529#pullrequestreview-567793308.

There are a few of us in @kubernetes/sig-release-leads that hold multiple roles...
Yourself, @saschagrunert, and I are:

  • SIG leadership
  • Release Managers
  • RelEng subproject owners

We need to codify this somewhere, but I've been roughly going by these rules:

  • All SIG Release leadership should be in sig-release-leads and release-team-leads
  • Only Release Managers and Release Manager Associates should be in release-managers
  • Only full-fledged members of both Release Managers and the Product Security Committee should be in security-release-team

/hold
/retitle slack-config: Add Jeremy Rickard as a SIG Release Technical Lead

@@ -20,6 +20,7 @@ usergroups:
- gianarb # Release Manager Associate
- hasheddan # subproject owner / Release Manager
- idealhack # Release Manager
- jeremyrickard # subproject owner / Release Manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop.

@@ -94,6 +96,7 @@ usergroups:
- feiskyer # Release Manager
- hasheddan # subproject owner / Release Manager
- idealhack # Release Manager
- jeremyrickard # subproject owner / Release Manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop.

@k8s-ci-robot k8s-ci-robot changed the title Add jeremyrickard to sig-release slack groups slack-config: Add Jeremy Rickard as a SIG Release Technical Lead Jan 14, 2021
Adds jeremyrickard to sig-release slack groups as part of technical lead
onboarding.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan
Copy link
Contributor Author

@justaugustus updates made 👍

@justaugustus
Copy link
Member

Awesome, thanks @hasheddan!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0774370 into kubernetes:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants