Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for kubeadm-local-cluster tool #629

Closed
wants to merge 1 commit into from

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented May 17, 2017

Moving the proposal from kubernetes/kubeadm#236 per sig-cluster-lifecycle suggestion.

A version of the local cluster tool described here exists in the form of kubeadm-dind-cluster project (Go version is not here yet). The differences are described closer to the end of the document.

It's yet to be decided where the tool should live (keep the old location in Mirantis github repo, move to kubernetes-incubator or some other option).

I'll be showing a demo of existing DIND solution (kubeadm-dind-cluster) today on ContribX meeting (17 May 2017).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@0xmichalis
Copy link
Contributor

@kubernetes/sig-testing-feature-requests assuming you guys are responsible for hack/local-up-cluster - this should be of interest to you

@k8s-ci-robot
Copy link
Contributor

@Kargakis: These labels do not exist in this repository: sig/testing.

In response to this:

@kubernetes/sig-testing-feature-requests assuming you guys are responsible for hack/local-up-cluster - this should be of interest to you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timothysc
Copy link
Member

timothysc commented May 26, 2017

I'm all for replacing local-up-cluster .
@kubernetes/sig-cluster-lifecycle-feature-requests @ncdc @castrojo

@k8s-ci-robot
Copy link
Contributor

@timothysc: These labels do not exist in this repository: sig/cluster-lifecycle.

In response to this:

I'm all for replacing local-up-cluster .
@kubernetes/sig-cluster-lifecycle-feature-requests @ncdc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer
Copy link
Member

local-up-cluster.sh supports all runtimes (including CRI runtimes) today, how kubeadm-local-cluster could support other runtimes besides docker, since dind is only for docker?

@0xmichalis
Copy link
Contributor

@feiskyer I don't think local-up-cluster is going away, this should just replace the docker parts of it.

@ivan4th
Copy link
Contributor Author

ivan4th commented May 26, 2017

@feiskyer re CRI implementations, actually we use DIND just fine for Virtlet work, also Virtlet's demo script is based on DIND, too. We can do this thanks to the CRI proxy mechanism which makes it possible to run CRI implementations as DaemonSets and deploy them via single kubectl create -f ... command. Although depending on the purpose of particular CRI implementation this may not be always the best approach, we can extract this component from Virtlet easily if other CRI implementation writers are interested in it.

@Kargakis yes, I think the DIND mechanism cannot completely replace local-up-cluster. Yet I think that after Go rewrite it'll be possible to make multiple backends for this local cluster tool, including one that works in a way similar to local-up-cluster. This is currently out of scope of this proposal though.

@danehans
Copy link

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2017
@k8s-github-robot
Copy link

This PR hasn't been active in 112 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @calebamiles @idvoretskyi @ivan4th

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
* sort steering by last name

cc @craigbox

* Sort April based on Kyle Nassi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants