-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Versioned Component Configuration Files doc #6758
Conversation
/assign @tpepper @justaugustus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mtaufen!
/hold I've made a few style suggestions, in case you want to pick them, but I'm fine w/ approving as-is
/lgtm
/approve
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Whoops, I somehow missed that a review happened on this one. I'll see if I can update it in the next couple weeks. Thanks! /remove-lifecycle stale |
Adds the VCCF doc to the community archive for wg-component-standard. While this doc predates the WG, it is a primary historical record of ComponentConfig's early development, which was primarily driven by that WG.
/hold cancel |
@justaugustus updated, looks like it needs a re-lgtm, thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @mtaufen!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, mtaufen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds the VCCF doc to the community archive for wg-component-standard.
While this doc predates the WG, it is a primary historical record of
ComponentConfig's early development, which was primarily driven by
that WG.