Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Versioned Component Configuration Files doc #6758

Merged
merged 1 commit into from Nov 21, 2022

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Jul 22, 2022

Adds the VCCF doc to the community archive for wg-component-standard.
While this doc predates the WG, it is a primary historical record of
ComponentConfig's early development, which was primarily driven by
that WG.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 22, 2022
@mtaufen
Copy link
Contributor Author

mtaufen commented Jul 26, 2022

/assign @tpepper @justaugustus

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtaufen!
/hold I've made a few style suggestions, in case you want to pick them, but I'm fine w/ approving as-is
/lgtm
/approve

archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
archive/wg-component-standard/component-config/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2022
@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 1, 2022

Whoops, I somehow missed that a review happened on this one. I'll see if I can update it in the next couple weeks. Thanks!

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2022
Adds the VCCF doc to the community archive for wg-component-standard.
While this doc predates the WG, it is a primary historical record of
ComponentConfig's early development, which was primarily driven by
that WG.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2022
@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 19, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2022
@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 19, 2022

@justaugustus updated, looks like it needs a re-lgtm, thanks for your review!

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @mtaufen!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d567792 into kubernetes:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants