Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SIG Release info #917

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Update SIG Release info #917

merged 2 commits into from
Aug 16, 2017

Conversation

calebamiles
Copy link
Contributor

We moved into the top level kubernetes/sig-release but need to
include ourselves in the canonical list

@calebamiles calebamiles added kind/documentation Categorizes issue or PR as related to documentation. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 15, 2017
@calebamiles calebamiles requested a review from jbeda August 15, 2017 23:10
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2017
@cblecker
Copy link
Member

Can you run make on this and commit the changes?

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2017
@calebamiles
Copy link
Contributor Author

No @cblecker I can't, running on master from a clean checkout

docker build -q -t kube-communitydocs -f generator/Dockerfile generator
sha256:dd005cf512b074016d7cd0146c18872bf5eed75d55079071e7e52e2fbcc77815
docker run --rm -e WG -e SIG -v /home/caleb/workspace/community:/go/src/app/generated kube-communitydocs app
2017/08/16 00:04:00 open generated/sigs.yaml: permission denied
make: *** [Makefile:13: generate] Error 1

SIG release is now a top level repository so the sig-release directory is empty except for a forwarding link to the new location. The proposed changes were produced by running

docker run 6da0415bdb00 go-wrapper run app.go

by hand and then copying the pertinent changes (only affecting sig-list.md) back into the tree. I believe the README needs to be updated because trying to update the docs for a single SIG produces

make: *** No rule to make target 'gen-docs'.  Stop.

I have also made sure to do the "remove all containers and images" song and dance.

@pwittrock
Copy link
Member

pwittrock commented Aug 16, 2017 •
edited
Loading

LGTM from my side

@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

Can we get an updated sig-release/README.md too?

(We discussed on slack making the script work with SELinux with a :Z option on the docker mount in the script)

@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

@cblecker It looks like the submit queue is barfing on this (because sig-release/README.md hasn't been update, I think) but there is no way to tell what is going on from the "Details" link above.

jbeda
jbeda reviewed Aug 16, 2017
View reviewed changes
Copy link
Contributor

@jbeda jbeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but sig-release/README.md needs to be updated.

@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

Canceled as there was a presubmit check for this stuff but it looks to be disabled now. Was going to rely on that. I'll wait until README.md is updated to LGTM.

caleb miles added 2 commits August 15, 2017 17:58
Update SIG Release info
0dc8be8 
We moved into the top level `kubernetes/sig-release` but need to
include ourselves in the canonical list
The SIG list generation tool supports SELinux
4cf32c0 
According to the [Docker documentation](https://docs.docker.com/engine/admin/volumes/bind-mounts/#configure-the-selinux-label)
additional options are required for bind mounts on systems where SELinux is enabled.
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2017
@jbeda
Copy link
Contributor

jbeda commented Aug 16, 2017

/lgtm

Thanks @calebamiles! Hopefully we can make this more automatic and more correct over time.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f14b3a0 into kubernetes:master Aug 16, 2017
@cblecker cblecker mentioned this pull request Aug 16, 2017
Closed
@calebamiles calebamiles deleted the update-sig-release branch August 16, 2017 16:46
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
@istio-testing
Automator: update common-files@master in istio/community@master (kube…
8dfbe00 
…rnetes#917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeda jbeda jbeda left review comments

Assignees

@jbeda jbeda

@pwittrock pwittrock

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@calebamiles @cblecker @pwittrock @jbeda @k8s-github-robot @k8s-ci-robot