Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify vendored modules in pull requests #3993

Closed
eloyekunle opened this issue Jul 1, 2019 · 1 comment
Closed

Verify vendored modules in pull requests #3993

eloyekunle opened this issue Jul 1, 2019 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@eloyekunle
Copy link
Contributor

eloyekunle commented Jul 1, 2019

What would you like to be added

Add scripts to update vendor and verify vendor. Vendor verification should run in Travis for all pull requests to ensure the go.mod file includes the correct dependencies.
The update vendor script will run go mod tidy to prune all extraneous requirements.

Why is this needed

To ensure that the contents of the go.mod file and the /vendor directory are always correct and verified.

Comments

This is based on the current implementation in the Kubernetes repository:

  1. The update-vendor.sh script.
  2. The verify-vendor.sh script.
@eloyekunle eloyekunle added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 1, 2019
@eloyekunle
Copy link
Contributor Author

Closing. This is unnecessary since we're not keeping the vendor directory anymore. Tidying and bumping packages can be done manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant