Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CRD Object Detail Page #4123

Closed
3 tasks done
eloyekunle opened this issue Jul 25, 2019 · 6 comments · Fixed by #4155
Closed
3 tasks done

Implement CRD Object Detail Page #4123

eloyekunle opened this issue Jul 25, 2019 · 6 comments · Fixed by #4155
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@eloyekunle
Copy link
Contributor

eloyekunle commented Jul 25, 2019

What would you like to be added

Objects created as CRDs can contain arbitrary JSON/YAML data. It is difficult to display the data in an intuitive way that captures the intended use of the resource. It is proposed that the entire arbitrary JSON/YAML data be shown in a structured text format using the library currently used for the edit dialog.

Current Object Detail Page
image

TODO

  • Implement Object Data view.
  • Add Edit & Delete ActionBar buttons.
  • Add Events Section.
Comments

Credits: the TPR design proposal.
Ref: #4030
Ref: #2493

@eloyekunle eloyekunle added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2019
@eloyekunle eloyekunle mentioned this issue Jul 25, 2019
6 tasks
@eloyekunle
Copy link
Contributor Author

Current view of the object detail page:

image

@maciaszczykm
Copy link
Member

@eloyekunle Few remarks:

  • Ensure that fields from the list are in the details view (is kind there?). You can do it using new tab named Information like in other resources.
  • I think there is no need to display whole YAML/JSON in spec. I'd display spec only there. We have metadata above. WDYT?

@eloyekunle
Copy link
Contributor Author

The CRD object spec may vary across the CRDs, since each CRD defines the possible fields for the objects. So, I don't think we can come up with a predefined set of fields to display for the object information.
Is my understanding correct?

@maciaszczykm
Copy link
Member

@eloyekunle Yes, but you can display only part of the YAML.

@eloyekunle
Copy link
Contributor Author

Do you mean e.g. just showing the spec and status nodes of the YAML?

@maciaszczykm
Copy link
Member

Yes, exactly. But the whole YAML is also fine in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants