Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having trouble adding languages to i18n #4763

Closed
hwdef opened this issue Jan 13, 2020 · 6 comments
Closed

Having trouble adding languages to i18n #4763

hwdef opened this issue Jan 13, 2020 · 6 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@hwdef
Copy link
Member

hwdef commented Jan 13, 2020

What should be cleaned up or changed

docs/developer/internationalization.md

Provide any links for context

I am doing the work of adding languages follow internationalization.md , and I find two troubles:

  1. I cannot find xfillmergeOptions array , only xliffmergeOptions

image

image

2.I add zh-cn in xliffmergeOptions array ,and I run

npm run fix:i18n

the result is

image

Is this a bug or am I running the wrong process?

@hwdef hwdef added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 13, 2020
@floreks
Copy link
Member

floreks commented Jan 13, 2020

Those steps are not complete.

After messages.zh-cn.xlf is generated, create directory for your translation i.e. zh-cn and move the translation file there. Then add zh-cn to the locale_conf.json file. That should be all. Then you can translate the file.

@hwdef
Copy link
Member Author

hwdef commented Jan 13, 2020

@floreks
Thanks for your answer.
How should problem 1 be solved?Is it a spelling mistakes? Modify the array name in the internationalization.md?
I can perfect this document

@maciaszczykm
Copy link
Member

@hwdef You can fix the mistake and add the description from @floreks to it.

@hwdef
Copy link
Member Author

hwdef commented Jan 13, 2020

@maciaszczykm
OK, I will do these.

@floreks
Copy link
Member

floreks commented Jan 16, 2020

Updated Documentation in #4792

/close

@k8s-ci-robot
Copy link
Contributor

@floreks: Closing this issue.

In response to this:

Updated Documentation in #4792

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

4 participants