-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using takeUntilDestroyed after upgrading to Angular 16 #8372
using takeUntilDestroyed after upgrading to Angular 16 #8372
Conversation
6ab0311
to
c25cdf2
Compare
c25cdf2
to
81d6011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks much cleaner.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, romdhanisam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #8372 +/- ##
==========================================
- Coverage 43.69% 42.23% -1.47%
==========================================
Files 55 219 +164
Lines 1277 12184 +10907
Branches 179 179
==========================================
+ Hits 558 5146 +4588
- Misses 681 6740 +6059
- Partials 38 298 +260 |
Code needs formatting. |
PR merged before fixing formatting in ts files, see #8376 |
No description provided.