using takeUntilDestroyed after upgrading to Angular 16 #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
romdhanisam
force-pushed
the
feat/angular-16-takeUntilDestroyed
branch
from
6ab0311
to
c25cdf2
Compare
romdhanisam
force-pushed
the
feat/angular-16-takeUntilDestroyed
branch
from
c25cdf2
to
81d6011
Compare
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, romdhanisam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #8372 +/- ##
==========================================
- Coverage 43.69% 42.23% -1.47%
==========================================
Files 55 219 +164
Lines 1277 12184 +10907
Branches 179 179
==========================================
+ Hits 558 5146 +4588
- Misses 681 6740 +6059
- Partials 38 298 +260 |
|
Code needs formatting. |
|
PR merged before fixing formatting in ts files, see #8376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.