-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Test) Fixed namespace-settings-global setting - added tests #8410
base: master
Are you sure you want to change the base?
feat(Test) Fixed namespace-settings-global setting - added tests #8410
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: romdhanisam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
218c8d1
to
b04aa1e
Compare
b04aa1e
to
27b3cfa
Compare
The use of takeUntilDestroyed after upgrading to Angular 16 #8372 shows us that some component are not properly destroyed overall on changing views. Unit tests can help demonstrate that. |
/retest |
/test all |
@shu-mutou: No presubmit jobs available for kubernetes/dashboard@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Navigating out of setting causes an error.
Version v3.0.0-alpha0-233-g7a059ac99