-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update helm chart to work with kong as a gateway #8735
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8735 +/- ##
==========================================
+ Coverage 35.77% 35.80% +0.02%
==========================================
Files 252 252
Lines 10708 10705 -3
Branches 156 157 +1
==========================================
+ Hits 3831 3833 +2
+ Misses 6626 6621 -5
Partials 251 251 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Helm
This is a complete overhaul of the helm chart. It includes:
kong
deployment as a default gateway for the Kubernetes Dashboard. This is a required dependency.values.yaml
→web.settings.configMap
entry.app.ingress.enabled=true
andapp.ingress.path=/dashboard
. It would serve Dashboard onhttps://localhost/dashboard
by default.app.ingress.useDefaultAnnotations=false
ingressClassName
can now be skipped from spec and it should fallback to using default ingress class (if configured). It is controlled byapp.ingress.useDefaultIngressClass
.app.mode=api
kong.enabled=false
api.containers.args={--metrics-provider=none}
cert-manager
,nginx
andmetrics-server
are now disabled by default. Onlykong
dependency is required.clusterReadOnlyRole
has been removed since it is no longer possible to use Dashboard permissions to access the cluster. User access is required at all times.Web
index.html
to dynamically generate<base href=...>
tag.API
csrf-key
argument - Base64 encoded random 256 bytes key. Can be loaded from 'CSRF_KEY' environment variable.Auth
csrf-key
argument - Base64 encoded random 256 bytes key. Can be loaded from 'CSRF_KEY' environment variable.Fixes
Some other issues were fixed along the way.
Fixes #8172
Fixes #8340
Fixes #8148
Fixes #8137
Fixes #8053
Fixes #8224
Fixes #3686