Helm Chart v7.0.3 is Broken

[jashandeep-sohi]

What happened?

Helm chart has multiple tempting bugs.

• Settings a app.nodeSelector causes the API deployment to be rendered incorrectly. I think this is because nodeSelector is wrapped in a with https://github.com/kubernetes/dashboard/blob/cc7a08fb3f0fc4e3c792a830fd8321f68f6cfe1e/charts/helm-chart/kubernetes-dashboard/templates/deployments/api.yaml#L90C28-L90C40, but by default that value is empty

  dashboard/charts/helm-chart/kubernetes-dashboard/values.yaml

  Line 153 in cc7a08f

  nodeSelector: {}

  . Not a show stopper, I can work around it by repeating web.nodeSelector & api.nodeSelector.

• With enabling the PDB, the apiVersion ends up on the same line as the license because of the trailing chomping template directive

  dashboard/charts/helm-chart/kubernetes-dashboard/templates/security/pdb.yaml

  Line 15 in cc7a08f

  {{- if .Values.app.security.podDisruptionBudget.enabled -}}

  (side-note: why spam the license in every file?)

*This is not a exhaustive list, just the issues I've run into.

What did you expect to happen?

Templates to be rendered correctly.

How can we reproduce it (as minimally and precisely as possible)?

• helm -n kube-dash template kube-dash kubernetes-dashboard/kubernetes-dashboard --kube-version 1.22 --set app.scheduling.nodeSelector.test=1

• helm -n kube-dash template kube-dash kubernetes-dashboard/kubernetes-dashboard --kube-version 1.22 --set app.security.podDisruptionBudget.enabled=true -s templates/security/pdb.yaml
  ---
  # Source: kubernetes-dashboard/templates/security/pdb.yaml
  # Copyright 2017 The Kubernetes Authors.
  #
  # Licensed under the Apache License, Version 2.0 (the "License");
  # you may not use this file except in compliance with the License.
  # You may obtain a copy of the License at
  #
  #     http://www.apache.org/licenses/LICENSE-2.0
  #
  # Unless required by applicable law or agreed to in writing, software
  # distributed under the License is distributed on an "AS IS" BASIS,
  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  # See the License for the specific language governing permissions and
  # limitations under the License.apiVersion: policy/v1
  kind: PodDisruptionBudget
  metadata:
    labels:
      helm.sh/chart: kubernetes-dashboard-7.0.3
      app.kubernetes.io/instance: kube-dash
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/part-of: kubernetes-dashboard
    annotations:
    name: kube-dash-kubernetes-dashboard
  spec:
    selector:
      matchLabels:
      
        app.kubernetes.io/instance: kube-dash
        app.kubernetes.io/part-of: kubernetes-dashboard
  

Anything else we need to know?

$ helm version
version.BuildInfo{Version:"v3.12.1", GitCommit:"v3.12.1", GitTreeState:"", GoVersion:"go1.20.5"}

What browsers are you seeing the problem on?

No response

Kubernetes Dashboard version

v3.0.0-alpha0

Kubernetes version

1.22

Dev environment

No response

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vaibhav2107]

/remove-lifecycle stale