Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunAsUserName for Windows #1043

Closed
4 tasks done
PatrickLang opened this issue May 3, 2019 · 42 comments
Closed
4 tasks done

RunAsUserName for Windows #1043

PatrickLang opened this issue May 3, 2019 · 42 comments
Assignees
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@PatrickLang
Copy link
Contributor

PatrickLang commented May 3, 2019

Enhancement Description

Existing issue:
kubernetes/kubernetes#73387

This existing PR will be updated and merged: kubernetes/kubernetes#73609

Past work in CRI layer:
kubernetes/kubernetes#64009

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 3, 2019
@PatrickLang
Copy link
Contributor Author

PatrickLang commented May 3, 2019

/sig windows
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 3, 2019
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2019
@michmike michmike added this to Backlog (v.1.15) in SIG-Windows May 3, 2019
@kacole2 kacole2 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 6, 2019
@makoscafee
Copy link
Member

makoscafee commented May 10, 2019

Hey, @PatrickLang 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions

@kacole2
Copy link
Member

kacole2 commented May 30, 2019

Hi @PatrickLang, today is code freeze for the 1.15 release cycle. The k/k PRs kubernetes/kubernetes#73609 has not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there a high confidence this will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@PatrickLang PatrickLang moved this from Backlog (v.1.15) to Backlog (v1.16) in SIG-Windows May 30, 2019
@PatrickLang
Copy link
Contributor Author

PatrickLang commented May 30, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 30, 2019
@PatrickLang
Copy link
Contributor Author

PatrickLang commented May 30, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone May 30, 2019
@PatrickLang PatrickLang moved this from Backlog (v1.16) to In Progress+Review in SIG-Windows Jul 2, 2019
@evillgenius75
Copy link

evillgenius75 commented Jul 8, 2019

Hi @PatrickLang , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating to alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

If there are any other PRs besides kubernetes/kubernetes#73609, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Jul 18, 2019

hi @evilgenius75 - it's merged in kubernetes/kubernetes#79489 :)
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 18, 2019

@PatrickLang: Closing this issue.

In response to this:

hi @evilgenius75 - it's merged in kubernetes/kubernetes#79489 :)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG-Windows automation moved this from In Progress+Review to Done (v1.16) Jul 18, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 23, 2019

@PatrickLang we need to keep this open until the feature has graduated to stable. Is there any other reason why it should be closed?

@kacole2 kacole2 reopened this Jul 23, 2019
SIG-Windows automation moved this from Done (v1.16) to Backlog Jul 23, 2019
@PatrickLang PatrickLang moved this from Backlog to Backlog (v1.16) in SIG-Windows Jul 23, 2019
@sethmccombs
Copy link

sethmccombs commented Aug 4, 2019

Hey @PatrickLang

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Aug 12, 2019

doc PR: kubernetes/website#15378

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Aug 12, 2019

test PR: kubernetes/kubernetes#79539

@PatrickLang PatrickLang moved this from Backlog (v1.16) to In Progress+Review in SIG-Windows Aug 13, 2019
@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@PatrickLang code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? Looks like only thing we're waiting on is kubernetes/kubernetes#79539 to be merged.

@iheanyi1
Copy link

iheanyi1 commented Feb 4, 2020

Hello @PatrickLang ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Warm regards,

chima

@PatrickLang PatrickLang moved this from Done (v1.16) to In Progress (v1.18) in SIG-Windows Feb 26, 2020
@PatrickLang
Copy link
Contributor Author

PatrickLang commented Feb 26, 2020

@iheanyi1 - have doc PR attached. code PRs are merged.

/milestone v1.18

@PatrickLang PatrickLang moved this from In Progress (v1.18) to In Review (v1.18) in SIG-Windows Mar 2, 2020
@helayoty
Copy link
Member

helayoty commented Mar 4, 2020

Hi @PatrickLang We're only a few days out from code freeze now. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

@marosset
Copy link
Contributor

marosset commented Mar 4, 2020

@helayoty we want to try and get this in for 1.18 since the code PRs already merged.
I DM'd @tengqm on slack to take a look since this just needs approval from sig-docs-en-owners

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Mar 12, 2020

All PRs merged. Thanks for all the hard work everyone!

SIG-Windows automation moved this from In Review (v1.18) to Done (v1.18) Mar 12, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Apr 16, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

Hi @PatrickLang, since this enhancement graduated to stable in 1.18, can you please mark the KEP as implemented?

@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

/reopen
(reopening the issue until the KEP is marked implemented)

@palnabarun palnabarun reopened this Apr 16, 2020
SIG-Windows automation moved this from Done (v1.18) to Backlog Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2020

@palnabarun: Reopened this issue.

In response to this:

/reopen
(reopening the issue until the KEP is marked implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

marosset commented Apr 17, 2020

@palnabarun I can update the KEP.

@palnabarun
Copy link
Member

palnabarun commented Apr 17, 2020

@marosset Thank you 🙂

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 27, 2020
@marosset
Copy link
Contributor

marosset commented May 4, 2020

The KEP covers more than than just the RunAsUserName feature/API work - I think everything in the KEP has been implemented but am checked with @ddebroy

@ddebroy
Copy link
Member

ddebroy commented May 5, 2020

All aspects of the KEP (including RunAsUserName and GMSA credspecs) has indeed been implemented and graduated to stable. So I went ahead and marked the KEP implemented in #1743

As @marosset correctly pointed out above, the KEP covers the overall windowsOptions in securityContext in pod specs. We wrote that KEP to drive the API discussion and reviews around windowsOptions - which is a broader topic than runAsUserName that is the focus of this issue. GMSA had it's own dedicated KEP (since there was quite a lot of details to clarify there) but a dedicated KEP for runAsUserName was considered unnecessary as the concept was already well understood from the perspective of API reviews.

@palnabarun
Copy link
Member

palnabarun commented May 11, 2020

Thank you @marosset @ddebroy for updating the status of the KEP. 👍

/close

(since the corresponding KEP has been implemented)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 11, 2020

@palnabarun: Closing this issue.

In response to this:

Thank you @marosset @ddebroy for updating the status of the KEP. 👍

/close

(since the corresponding KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG-Windows automation moved this from Backlog to Done (v1.18) May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests