-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunAsUserName for Windows #1043
Comments
/sig windows |
Hey, @PatrickLang 👋 I'm the v1.15 docs Lead. Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions |
Hi @PatrickLang, today is code freeze for the 1.15 release cycle. The k/k PRs kubernetes/kubernetes#73609 has not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there a high confidence this will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception. |
/milestone clear |
/milestone v1.16 |
Hi @PatrickLang , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating to alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label. If there are any other PRs besides kubernetes/kubernetes#73609, please list all relevant k/k PRs in this issue so they can be tracked properly. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
hi @evilgenius75 - it's merged in kubernetes/kubernetes#79489 :) |
@PatrickLang: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@PatrickLang we need to keep this open until the feature has graduated to stable. Is there any other reason why it should be closed? |
Hey @PatrickLang I'm one of the v1.16 docs shadows. If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions! |
doc PR: kubernetes/website#15378 |
test PR: kubernetes/kubernetes#79539 |
@PatrickLang code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? Looks like only thing we're waiting on is kubernetes/kubernetes#79539 to be merged. |
Hello @PatrickLang , I'm 1.18 docs shadow. Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so) If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions! Warm regards, chima |
@iheanyi1 - have doc PR attached. code PRs are merged. /milestone v1.18 |
Hi @PatrickLang We're only a few days out from code freeze now. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push? |
All PRs merged. Thanks for all the hard work everyone! |
/stage stable |
Hi @PatrickLang, since this enhancement graduated to stable in 1.18, can you please mark the KEP as |
/reopen |
@palnabarun: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@palnabarun I can update the KEP. |
@marosset Thank you 🙂 |
The KEP covers more than than just the RunAsUserName feature/API work - I think everything in the KEP has been implemented but am checked with @ddebroy |
All aspects of the KEP (including As @marosset correctly pointed out above, the KEP covers the overall |
@palnabarun: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement Description
RunAsUserName
field to set the user for a container's initial process on WindowsThis covers both APIs that needed to be reviewed together, and it's implementable.
Existing issue:
kubernetes/kubernetes#73387
This existing PR will be updated and merged: kubernetes/kubernetes#73609
Past work in CRI layer:
kubernetes/kubernetes#64009
The text was updated successfully, but these errors were encountered: