Removing beta references on RunAsUserName page #19016

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michmike

/lgtm
/approve

marosset · 2020-02-25T22:23:30Z

/assign @tengqm

tengqm · 2020-02-26T00:59:21Z

/lgtm

zacharysarah · 2020-03-04T21:27:43Z

/assign @VineethReddy02

michmike

/lgtm
/approve

sftim

@marosset, remember also to update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

content/en/docs/tasks/configure-pod-container/configure-runasusername.md

sftim · 2020-03-04T22:29:46Z

content/en/docs/tasks/configure-pod-container/configure-runasusername.md

@@ -6,14 +6,8 @@ weight: 20

 {{% capture overview %}}

-{{< feature-state for_k8s_version="v1.17" state="beta" >}}
-
 This page shows how to enable and use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.


Suggested change

This page shows how to enable and use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.

This page shows how to use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.

sftim · 2020-03-04T22:33:31Z

/lgtm cancel

I'd expect to see an update to include the feature and its history in the feature gates table.

marosset · 2020-03-05T03:30:13Z

@sftim Please take another look and thanks for the feedback!

michmike

just one nit change

content/en/docs/reference/command-line-tools-reference/feature-gates.md

michmike

/lgtm
/approve

sftim

/lgtm

(see comments)

sftim · 2020-03-05T20:30:18Z

content/en/docs/tasks/configure-pod-container/configure-runasusername.md

-{{< note >}}
-This feature is in beta. The overall functionality for `RunAsUserName` will not change, but there may be some changes regarding the username validation.
-{{< /note >}}
+This page shows how to use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.


An observation. With the documentation style guide in mind, I'd write something like:

Suggested change

This page shows how to use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.

This page shows how to use the `runAsUserName` setting for Pods and containers that will run on Windows nodes. This is roughly equivalent to the Linux-specific `runAsUser` setting, allowing you to run applications in a container as a different username than the default.

(technical detail, also in the original: is runAsUser Linux-specific? What about other POSIX-like platforms?)

This text was in the previous revision so I'm fine leaving it in. It'd be nice to see this tidied up for GA though.

Updated the working here and in feature-gates.md.
(note: I left in the Linux-specific comment for now - as I'm not positive this works for all posix platforms)

VineethReddy02 · 2020-03-07T13:08:11Z

👋 Please rebase this PR on dev-1.18 in order to avoid merge conflicts.

Feel free to /hold cancel after you've rebased.

/hold

marosset · 2020-03-09T18:15:07Z

rebased on dev-1.18 and addressed some comments left by @sftim

/hold cancel

sftim

/lgtm

Might be worth fixing a nit I saw. It was wrong in the original so this PR isn't introducing an actual regression.

content/en/docs/tasks/configure-pod-container/configure-runasusername.md

michmike · 2020-03-12T02:01:07Z

/approve
/lgtm

michmike · 2020-03-12T02:01:29Z

thanks for all the changes @marosset !

VineethReddy02 · 2020-03-12T19:52:39Z

/lgtm
/approve

k8s-ci-robot · 2020-03-12T19:53:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michmike, VineethReddy02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [VineethReddy02]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020

k8s-ci-robot requested review from daminisatya and kbhawkey February 6, 2020 21:59

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 6, 2020

k8s-ci-robot added this to the 1.18 milestone Feb 19, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2020

k8s-ci-robot requested review from michmike and PatrickLang February 25, 2020 18:46

michmike approved these changes Feb 25, 2020

View reviewed changes

k8s-ci-robot assigned michmike Feb 25, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2020

k8s-ci-robot assigned tengqm Feb 25, 2020

PatrickLang mentioned this pull request Feb 26, 2020

RunAsUserName for Windows kubernetes/enhancements#1043

Closed

4 tasks

k8s-ci-robot assigned VineethReddy02 Mar 4, 2020

michmike approved these changes Mar 4, 2020

View reviewed changes

sftim requested changes Mar 4, 2020

View reviewed changes

k8s-ci-robot assigned sftim Mar 4, 2020

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2020

marosset force-pushed the run-as-username-ga branch 2 times, most recently from a80a7e8 to c119b8a Compare March 5, 2020 03:22

michmike suggested changes Mar 5, 2020

View reviewed changes

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved

marosset force-pushed the run-as-username-ga branch from c119b8a to 7487c5b Compare March 5, 2020 18:22

michmike approved these changes Mar 5, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020

sftim reviewed Mar 5, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2020

marosset force-pushed the run-as-username-ga branch from 7487c5b to 2ccab7e Compare March 9, 2020 18:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020

sftim reviewed Mar 9, 2020

View reviewed changes

content/en/docs/tasks/configure-pod-container/configure-runasusername.md Outdated Show resolved Hide resolved

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020

Updating Windows RunAsUserName page to reflect feature going GA

7ede9b6

marosset force-pushed the run-as-username-ga branch from 2ccab7e to 7ede9b6 Compare March 9, 2020 18:52

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020

marosset added this to In Review (v1.18) in SIG-Windows Mar 10, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020

k8s-ci-robot merged commit 99052a4 into kubernetes:dev-1.18 Mar 12, 2020

SIG-Windows automation moved this from In Review (v1.18) to Done (v1.18) Mar 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing beta references on RunAsUserName page #19016

Removing beta references on RunAsUserName page #19016

marosset commented Feb 6, 2020

k8sio-netlify-preview-bot commented Feb 6, 2020 •

edited

Loading

marosset commented Feb 6, 2020

makoscafee commented Feb 19, 2020

marosset commented Feb 25, 2020

marosset commented Feb 25, 2020

k8s-ci-robot commented Feb 25, 2020

michmike left a comment

marosset commented Feb 25, 2020

tengqm commented Feb 26, 2020

zacharysarah commented Mar 4, 2020

michmike left a comment

sftim left a comment

sftim Mar 4, 2020

sftim commented Mar 4, 2020

marosset commented Mar 5, 2020

michmike left a comment

michmike left a comment

sftim left a comment

sftim Mar 5, 2020

marosset Mar 9, 2020

VineethReddy02 commented Mar 7, 2020

marosset commented Mar 9, 2020

sftim left a comment

michmike commented Mar 12, 2020

michmike commented Mar 12, 2020

VineethReddy02 commented Mar 12, 2020

k8s-ci-robot commented Mar 12, 2020

	This page shows how to enable and use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.
	This page shows how to use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.

Removing beta references on RunAsUserName page #19016

Removing beta references on RunAsUserName page #19016

Conversation

marosset commented Feb 6, 2020

k8sio-netlify-preview-bot commented Feb 6, 2020 • edited Loading

marosset commented Feb 6, 2020

makoscafee commented Feb 19, 2020

marosset commented Feb 25, 2020

marosset commented Feb 25, 2020

k8s-ci-robot commented Feb 25, 2020

michmike left a comment

Choose a reason for hiding this comment

marosset commented Feb 25, 2020

tengqm commented Feb 26, 2020

zacharysarah commented Mar 4, 2020

michmike left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

sftim Mar 4, 2020

Choose a reason for hiding this comment

sftim commented Mar 4, 2020

marosset commented Mar 5, 2020

michmike left a comment

Choose a reason for hiding this comment

michmike left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

sftim Mar 5, 2020

Choose a reason for hiding this comment

marosset Mar 9, 2020

Choose a reason for hiding this comment

VineethReddy02 commented Mar 7, 2020

marosset commented Mar 9, 2020

sftim left a comment

Choose a reason for hiding this comment

michmike commented Mar 12, 2020

michmike commented Mar 12, 2020

VineethReddy02 commented Mar 12, 2020

k8s-ci-robot commented Mar 12, 2020

k8sio-netlify-preview-bot commented Feb 6, 2020 •

edited

Loading