Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Windows RunAsUserName feature to GA #87790

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Moving Windows RunAsUserName feature to GA #87790

merged 1 commit into from
Feb 25, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Feb 3, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

What this PR does / why we need it:
This PR moves Windows RunAsUserName kubelet feature to GA

Which issue(s) this PR fixes:

[Enhancement]: RunAsUserName for Windows kubernetes/enhancements#1043

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Moving Windows RunAsUserName feature to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 3, 2020
@marosset
Copy link
Contributor Author

marosset commented Feb 3, 2020

/sig windows
/milestone v1.18

@k8s-ci-robot
Copy link
Contributor

@marosset: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/sig windows
/milestone v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@marosset
Copy link
Contributor Author

marosset commented Feb 3, 2020

I'll update the failing/remove the tests which check that RunAsUserName gets dropped in API calls when the feature is disabled.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2020
@marosset
Copy link
Contributor Author

marosset commented Feb 4, 2020

/test pull-kubernetes-e2e-aks-engine-azure-windows

@PatrickLang PatrickLang added this to In Progress (v1.18) in SIG-Windows Feb 5, 2020
@PatrickLang PatrickLang moved this from In Progress (v1.18) to In Review (v1.18) in SIG-Windows Feb 5, 2020
@marosset
Copy link
Contributor Author

marosset commented Feb 6, 2020

/retest

@marosset marosset mentioned this pull request Feb 6, 2020
Merged
@marosset marosset force-pushed the windows-run-as-username-stable branch from 1a6761e to 630cc92 Compare February 7, 2020 16:14
@marosset
Copy link
Contributor Author

marosset commented Feb 7, 2020

/retest

@marosset
Copy link
Contributor Author

marosset commented Feb 7, 2020

/test pull-kubernetes-e2e-aks-engine-azure-windows
/test pull-kubernetes-kubemark-e2e-gce-big

@marosset
Copy link
Contributor Author

/cc @benmoss @ddebroy @PatrickLang @michmike for review by sig-windows

@k8s-ci-robot
Copy link
Contributor

@marosset: GitHub didn't allow me to request PR reviews from the following users: by, for, review.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @benmoss @ddebroy @PatrickLang @michmike for review by sig-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michmike
Copy link
Contributor

/assign @ddebroy

@PatrickLang
Copy link
Contributor

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 20, 2020
@PatrickLang
Copy link
Contributor

wow dropped some bits there coming back from PTO. not milestone 1.14
/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.14, v1.18 Feb 20, 2020
ddebroy
ddebroy reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits. LGTM overall with one comment.

pkg/features/kube_features.go Outdated Show resolved Hide resolved
@marosset marosset force-pushed the windows-run-as-username-stable branch from 630cc92 to d44a30f Compare February 20, 2020 22:44
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2020 •
edited
Loading

@marosset: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-windows 630cc9262e2faddda8e209ea5eaf6ef907cf9cf7 link /test pull-kubernetes-e2e-aks-engine-azure-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor Author

/retest

@marosset
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 24, 2020

/approve

will defer to sig-windows reviews for final lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@ddebroy
Copy link
Member

ddebroy commented Feb 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2020
michmike
michmike approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@michmike michmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, marosset, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 71b7b51 into kubernetes:master Feb 25, 2020
SIG-Windows automation moved this from In Review (v1.18) to Done (v1.18) Feb 25, 2020
@marosset marosset deleted the windows-run-as-username-stable branch February 25, 2020 22:32
@PatrickLang PatrickLang mentioned this pull request Feb 26, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy ddebroy left review comments

@michmike michmike michmike approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@justinsb justinsb Awaiting requested review from justinsb

@benmoss benmoss Awaiting requested review from benmoss

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

Assignees

@liggitt liggitt

@michmike michmike

@ddebroy ddebroy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@marosset @k8s-ci-robot @fejta-bot @michmike @PatrickLang @liggitt @ddebroy