Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recovery from volume expansion failure #1790

Open
gnufied opened this issue May 18, 2020 · 62 comments
Open

Support recovery from volume expansion failure #1790

gnufied opened this issue May 18, 2020 · 62 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@gnufied
Copy link
Member

gnufied commented May 18, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 18, 2020
@gnufied
Copy link
Member Author

gnufied commented May 18, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2020
@palnabarun
Copy link
Member

palnabarun commented May 18, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 18, 2020
@palnabarun
Copy link
Member

palnabarun commented May 18, 2020

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 18, 2020
@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 18, 2020
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 21, 2020
@palnabarun
Copy link
Member

palnabarun commented May 25, 2020

@gnufied -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@mikejoh
Copy link

mikejoh commented May 26, 2020

Hello, @gnufied ! 👋 I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

This is a friendly reminder that we're looking for a PR against kubernetes/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards,
Mikael.

@palnabarun
Copy link
Member

palnabarun commented Jun 1, 2020

Can you please link to all the implementation PR's here - k/k or otherwise?

@gnufied -- Pinging back as a friendly reminder for the above. 🙂

@gnufied
Copy link
Member Author

gnufied commented Jun 1, 2020

@palnabarun thanks for the reminder. there isn't one yet.

@gnufied
Copy link
Member Author

gnufied commented Jun 10, 2020

PR that implements necessary API changes and updates quota calculation code - kubernetes/kubernetes#91976

@mikejoh
Copy link

mikejoh commented Jun 15, 2020

Hi @gnufied! Friendly reminder regarding that docs placeholder PR against kubernetes/website (branch dev-1.19). The deadline for this have been pushed to Friday the 19th of June. Let me know if you have any questions!

@palnabarun
Copy link
Member

palnabarun commented Jun 18, 2020

Hi @gnufied -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. 🙂


The revised release schedule is:

  • Thursday, July 9th: Week 13 - Code Freeze
  • Thursday, July 16th: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

@gnufied
Copy link
Member Author

gnufied commented Jun 19, 2020

Docs PR - kubernetes/website#21920

@palnabarun
Copy link
Member

palnabarun commented Jul 6, 2020

Hi @gnufied 👋, I see that kubernetes/kubernetes#91976 and kubernetes/kubernetes#92770 yet to be merged. Do you think that they will be merged before the Code Freeze on Thursday, July 9th?

Thank you. 🙂


Code Freeze begins on Thursday, July 9th EOD PST

@annajung
Copy link
Member

annajung commented Jul 6, 2020

Hi @gnufied 👋 docs shadow here. Just a quick reminder to get your doc PR ready for review (Remove WIP/rebased/all ready to go) by EOD. Thank you!

@gnufied
Copy link
Member Author

gnufied commented Jul 6, 2020

@annajung done. thank you.

@palnabarun
Copy link
Member

palnabarun commented Jul 8, 2020

@gnufied -- Please note that tomorrow is Code Freeze.

If the enhancement misses the code freeze, you will need to file an Exception Request in order to get this back into 1.19.


Code Freeze begins on Thursday, July 9th EOD PST

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 10, 2020

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 10, 2020

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 10, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone Jul 10, 2020
@rhockenbury
Copy link

rhockenbury commented Mar 22, 2022

Hi @gnufied

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like all k/k PRs have been merged. Let me know if there are any other PRs that we should be tracking for 1.24 code freeze.

Let me know if you have any questions.

@gnufied
Copy link
Member Author

gnufied commented Mar 24, 2022

Hello - this feature will remain alpha in 1.24. We will try again in 1.25

@rhockenbury rhockenbury removed this from the v1.24 milestone Mar 25, 2022
@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 25, 2022
@xing-yang
Copy link
Contributor

xing-yang commented May 13, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 13, 2022
@jingxu97
Copy link
Contributor

jingxu97 commented May 18, 2022

/assigne @gnufied

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 3, 2022
@jasonbraganza
Copy link
Member

jasonbraganza commented Jun 3, 2022

Hello @gnufied 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • Please update the merged KEP as per the latest KEP template. Specifically:
    • Add a dedicated Design Details section (and move Test plan and Graduation criteria under this section)
  • Update the kep.yaml file to reflect the latest target stage and milestone information
  • Please update the Test plan section, so that it incorporates the updated detailed test plan section requirements
  • Please update the Graduation criteria section with latest target stage and milestone details.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jasonbraganza
Copy link
Member

jasonbraganza commented Jun 13, 2022

Hello @gnufied 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the pending items from above, done before enhancements freeze on Thursday, June 16, 2022 at 18:00 PM PT.

The currently pending items in the open PR #3362 are:

For note, the current status of the enhancement is atat-risk. Thank you!

@jasonbraganza
Copy link
Member

jasonbraganza commented Jun 20, 2022

Hello @gnufied. Just checking in, as we are four days away from the enhancements freeze.
Kindly get the above suggestions, implemented before then.
(The extended freeze date is Thursday, June 23, 2022 at 18:00 PM PT.)

Please note: the current status of the enhancement is at-risk.
Thank you.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 24, 2022

Hello, 1.25 Enhancements Lead here 👋. With Enhancements Freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP file using the latest template has been merged into the k/enhancements repo, with up to date latest milestone and stage
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Jun 24, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 24, 2022
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Sep 7, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

Hello @gnufied 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • Updated KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add a dedicated Design Details section (and move Test plan and Graduation criteria under this section)
  • Update the Test plan section to add the updated detailed test plan section requirements
  • Update the KEP file to reflect the latest target stage and milestone information
  • Please update the Graduation criteria section with latest target stage and milestone details.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README.

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests