Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: cpumanager: add options to reject non SMT-aligned workload #2625

Open
4 tasks done
fromanirh opened this issue Apr 14, 2021 · 29 comments
Open
4 tasks done

node: cpumanager: add options to reject non SMT-aligned workload #2625

fromanirh opened this issue Apr 14, 2021 · 29 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@fromanirh
Copy link
Contributor

fromanirh commented Apr 14, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 14, 2021
@fromanirh
Copy link
Contributor Author

fromanirh commented Apr 14, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2021
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2021
fromanirh added a commit to fromanirh/website that referenced this issue May 6, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
fromanirh added a commit to fromanirh/website that referenced this issue May 6, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@fromanirh fromanirh changed the title Add new cpumanager policies to enable finer grained thread allocation Add options to cpumanager policies to allow finer grained thread allocation May 7, 2021
@gracenng
Copy link
Member

gracenng commented May 10, 2021

Hi @fromanirh 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Thank you 😊

fromanirh added a commit to fromanirh/enhancements that referenced this issue May 10, 2021
See: kubernetes#2625 (comment)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@fromanirh
Copy link
Contributor Author

fromanirh commented May 10, 2021

Hi @fromanirh wave 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Done! thanks for checking!

@fromanirh fromanirh changed the title Add options to cpumanager policies to allow finer grained thread allocation node: cpumanager: add options to reject non SMT-aligned workload May 10, 2021
@fromanirh
Copy link
Contributor Author

fromanirh commented May 10, 2021

fixed the issue summary to make it consistent with the KEP

@gracenng
Copy link
Member

gracenng commented May 11, 2021

Hi @fromanirh 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@fromanirh
Copy link
Contributor Author

fromanirh commented May 11, 2021

Hi @fromanirh wave 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

Hi @gracenng ! thanks for checking in! I'm waiting for another review indeed. sig-node ack'd this enhancement (https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.y6vnh39j4mih) but unfortunately the sig is a bit overworked. I'll update as soon as possible.

fromanirh added a commit to fromanirh/website that referenced this issue May 12, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
fromanirh added a commit to fromanirh/website that referenced this issue May 20, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@gracenng
Copy link
Member

gracenng commented Jun 23, 2021

Hi @fromanirh 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as kubernetes/kubernetes#101432 has not been merged.
Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

@fromanirh
Copy link
Contributor Author

fromanirh commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

Hi Grace, thanks for the reminder. I'm working towards the final round of review.

fromanirh added a commit to fromanirh/website that referenced this issue Jul 8, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@fromanirh
Copy link
Contributor Author

fromanirh commented Jul 8, 2021

Please note that (of course once the implementation merges) we are planning to go beta not before two releases. So, if the implementation merges in 1.22, we will not promote to beta before 1.24 (was 1.23 before)

@fromanirh
Copy link
Contributor Author

fromanirh commented Jul 8, 2021

@gracenng FYI: kubernetes/kubernetes#101432 (comment)

@swatisehgal
Copy link
Contributor

swatisehgal commented Sep 6, 2021

Graduating CPU Manager Policy Options 1.23 Beta :

@swatisehgal
Copy link
Contributor

swatisehgal commented Sep 7, 2021

@gracenng Just as an FYI for you we are aiming to graduate this feature to Beta in 1.23 release.

@fromanirh
Copy link
Contributor Author

fromanirh commented Sep 14, 2021

Graduating CPU Manager Policy Options 1.23 Beta :

Related:

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 8, 2021

Related: #2993

@gracenng
Copy link
Member

gracenng commented Nov 9, 2021

Hi all, 1.23 Enhancements shadow here.

Looks like this enhancement's code PR (kubernetes/kubernetes#105012) is merged and all is ready for Code Freeze on November 16th. The status will remain as tracked.
Thanks!

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Nov 17, 2021

Hi all, 1.23 Enhancements shadow here.

Looks like this enhancement's code PR (kubernetes/kubernetes#105012) is merged and all is ready for Code Freeze on November 16th. The status will remain as tracked. Thanks!

@gracenng this issue is still having the label "tracked/no". Is it expected?

@gracenng
Copy link
Member

gracenng commented Nov 17, 2021

Hi, thanks for letting me know, looking into it

Edit: updated

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Nov 17, 2021
@fromanirh
Copy link
Contributor Author

fromanirh commented Nov 24, 2021

Graduating CPU Manager Policy Options 1.23 Beta :

Related:

All PRs merged!

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 9, 2022
@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 9, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 9, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2022
@swatisehgal
Copy link
Contributor

swatisehgal commented May 9, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 7, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@fromanirh
Copy link
Contributor Author

fromanirh commented Aug 8, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 6, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@fromanirh
Copy link
Contributor Author

fromanirh commented Nov 7, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Development

No branches or pull requests

10 participants