Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: cpumanager: add options to reject non SMT-aligned workload #2625

Open
4 tasks done
ffromani opened this issue Apr 14, 2021 · 32 comments
Open
4 tasks done

node: cpumanager: add options to reject non SMT-aligned workload #2625

ffromani opened this issue Apr 14, 2021 · 32 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@ffromani
Copy link
Contributor

ffromani commented Apr 14, 2021 •
edited

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 14, 2021
@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2021
@swatisehgal swatisehgal mentioned this issue Apr 23, 2021
Merged
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2021
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
@ffromani
cpumanager: document cpu manager policy options
ebad450 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
@ffromani
cpumanager: document cpu manager policy options
67bf178 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani mentioned this issue May 6, 2021
Merged
@ffromani ffromani changed the title Add new cpumanager policies to enable finer grained thread allocation Add options to cpumanager policies to allow finer grained thread allocation May 7, 2021
@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Thank you 😊

ffromani added a commit to ffromani/enhancements that referenced this issue May 10, 2021
@ffromani
address comments from enhancement shadow
0fd8392 
See: kubernetes#2625 (comment)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented May 10, 2021 •
edited

Hi @fromanirh wave 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Done! thanks for checking!

@ffromani ffromani changed the title Add options to cpumanager policies to allow finer grained thread allocation node: cpumanager: add options to reject non SMT-aligned workload May 10, 2021
@ffromani
Copy link
Contributor Author

fixed the issue summary to make it consistent with the KEP

@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@ffromani
Copy link
Contributor Author

ffromani commented May 11, 2021 •
edited

Hi @fromanirh wave 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

Hi @gracenng ! thanks for checking in! I'm waiting for another review indeed. sig-node ack'd this enhancement (https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.y6vnh39j4mih) but unfortunately the sig is a bit overworked. I'll update as soon as possible.

ffromani added a commit to ffromani/website that referenced this issue May 12, 2021
@ffromani
cpumanager: document cpu manager static policy options
967d197 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani mentioned this issue May 17, 2021
Closed
ffromani added a commit to ffromani/website that referenced this issue May 20, 2021
@ffromani
cpumanager: document cpu manager static policy options
773fc58 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@gracenng
Copy link
Member

Hi @fromanirh 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as kubernetes/kubernetes#101432 has not been merged.
Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@ffromani ffromani mentioned this issue Jul 1, 2021
Closed
@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

@ffromani
Copy link
Contributor Author

ffromani commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

Hi Grace, thanks for the reminder. I'm working towards the final round of review.

ffromani added a commit to ffromani/website that referenced this issue Jul 8, 2021
@ffromani
cpumanager: document cpu manager static policy options
63d5e8a 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

Please note that (of course once the implementation merges) we are planning to go beta not before two releases. So, if the implementation merges in 1.22, we will not promote to beta before 1.24 (was 1.23 before)

@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

@gracenng FYI: kubernetes/kubernetes#101432 (comment)

@SergeyKanzhelev
Copy link
Member

Hi all, 1.23 Enhancements shadow here.

Looks like this enhancement's code PR (kubernetes/kubernetes#105012) is merged and all is ready for Code Freeze on November 16th. The status will remain as tracked. Thanks!

@gracenng this issue is still having the label "tracked/no". Is it expected?

@gracenng
Copy link
Member

gracenng commented Nov 17, 2021 •
edited

Hi, thanks for letting me know, looking into it

Edit: updated

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Nov 17, 2021
@ffromani
Copy link
Contributor Author

Graduating CPU Manager Policy Options 1.23 Beta :

Related:

All PRs merged!

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 9, 2022
@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2022
@swatisehgal
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Aug 8, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@ffromani ffromani mentioned this issue Sep 27, 2022
Merged
@swatisehgal swatisehgal mentioned this issue Oct 6, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 7, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2023
@ffromani
Copy link
Contributor Author

ffromani commented Feb 6, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2023
@SergeyKanzhelev
Copy link
Member

@ffromani is this going to be worked on in 1.28?

@swatisehgal swatisehgal mentioned this issue May 9, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@salaxander @JamesLaverack @ehashman @kikisdeliveryservice @SergeyKanzhelev @swatisehgal @k8s-ci-robot @ffromani @gracenng @k8s-triage-robot