Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: cpumanager: add options to reject non SMT-aligned workload #2625

Open
8 of 12 tasks
ffromani opened this issue Apr 14, 2021 · 50 comments
Open
8 of 12 tasks

node: cpumanager: add options to reject non SMT-aligned workload #2625

ffromani opened this issue Apr 14, 2021 · 50 comments
Assignees
@ffromani
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@ffromani
Copy link
Contributor

ffromani commented Apr 14, 2021 •
edited by pacoxu
Loading

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 14, 2021
@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2021
@swatisehgal swatisehgal mentioned this issue Apr 23, 2021
Merged
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2021
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
@ffromani
cpumanager: document cpu manager policy options
ebad450 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
@ffromani
cpumanager: document cpu manager policy options
67bf178 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani mentioned this issue May 6, 2021
Merged
@ffromani ffromani changed the title Add new cpumanager policies to enable finer grained thread allocation Add options to cpumanager policies to allow finer grained thread allocation May 7, 2021
@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Thank you 😊

ffromani added a commit to ffromani/enhancements that referenced this issue May 10, 2021
@ffromani
address comments from enhancement shadow
0fd8392 
See: kubernetes#2625 (comment)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented May 10, 2021 •
edited
Loading

Hi @fromanirh wave 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Done! thanks for checking!

@ffromani ffromani changed the title Add options to cpumanager policies to allow finer grained thread allocation node: cpumanager: add options to reject non SMT-aligned workload May 10, 2021
@ffromani
Copy link
Contributor Author

fixed the issue summary to make it consistent with the KEP

@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@ffromani
Copy link
Contributor Author

ffromani commented May 11, 2021 •
edited
Loading

Hi @fromanirh wave 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

Hi @gracenng ! thanks for checking in! I'm waiting for another review indeed. sig-node ack'd this enhancement (https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.y6vnh39j4mih) but unfortunately the sig is a bit overworked. I'll update as soon as possible.

ffromani added a commit to ffromani/website that referenced this issue May 12, 2021
@ffromani
cpumanager: document cpu manager static policy options
967d197 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani mentioned this issue May 17, 2021
Closed
ffromani added a commit to ffromani/website that referenced this issue May 20, 2021
@ffromani
cpumanager: document cpu manager static policy options
773fc58 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@gracenng
Copy link
Member

Hi @fromanirh 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as kubernetes/kubernetes#101432 has not been merged.
Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@ffromani ffromani mentioned this issue Jul 1, 2021
Closed
@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

@ffromani
Copy link
Contributor Author

ffromani commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

Hi Grace, thanks for the reminder. I'm working towards the final round of review.

ffromani added a commit to ffromani/website that referenced this issue Jul 8, 2021
@ffromani
cpumanager: document cpu manager static policy options
63d5e8a 
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

Please note that (of course once the implementation merges) we are planning to go beta not before two releases. So, if the implementation merges in 1.22, we will not promote to beta before 1.24 (was 1.23 before)

@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

@gracenng FYI: kubernetes/kubernetes#101432 (comment)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@ffromani
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@kannon92
Copy link
Contributor

@ffromani is there plans to promote this to beta?

@kannon92 kannon92 moved this from Triage to Stale in SIG Node 1.32 KEPs planning Aug 30, 2024
@ffromani
Copy link
Contributor Author

ffromani commented Aug 30, 2024 •
edited
Loading

@ffromani is there plans to promote this to beta?

this is already beta. I'm aiming to GA in 1.32 or 1.33 depending on the SIG bandwidth

EDIT: correcting myself, here we introduced the CPUManager{Alpha,Beta}PolicyOptions which is outside the regular graduation flow. Regardless I'm aiming to GA using the aforementioned timeline

@kannon92
Copy link
Contributor

Please update the description then. Reading this it looks like alpha.

@ffromani
Copy link
Contributor Author

Please update the description then. Reading this it looks like alpha.

yes, I'll update shortly. xref: #2933

@kannon92 kannon92 moved this from Stale to Proposed for consideration in SIG Node 1.32 KEPs planning Aug 30, 2024
@ffromani
Copy link
Contributor Author

/assign

@ffromani
Copy link
Contributor Author

GA graduation notes:

@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 17, 2024
@shecodesmagic
Copy link

Hello @ffromani 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@shecodesmagic shecodesmagic moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 28, 2024
@ffromani
Copy link
Contributor Author

ffromani commented Oct 3, 2024 •
edited
Loading

Hi all, I'm fully busy with other work this cycle and despite the best efforts I won't be able to graduate this to GA in 1.32. I'm still committed to graduate to GA but we will need to wait 1.33. I'm fine dropping this enhancement from 1.32.
Some prerequisites (xref: kubernetes/kubernetes#127155) will be pushed forward anyway because will benefit other KEPs I'm helping with (and committed to) in the 1.32 timeframe.

@haircommander
Copy link
Contributor

/remove-milestone v1.32
/remove-label lead-opted-in

gotcha! I'll remove this from the milestone and we can revisit in 1.33

@haircommander haircommander moved this from Considered for release to Not for release in SIG Node 1.32 KEPs planning Oct 3, 2024
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2024
@dipesh-rawat
Copy link
Member

Hello @ffromani @haircommander 👋, 1.32 Enhancements team here.

Since this enhancement has been rescheduled for a future release, it's now marked as Deferred for the current v1.32 release cycle. Confirming this based on the comment #2625 (comment). Thanks!

@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Deferred in 1.32 Enhancements Tracking Oct 10, 2024
@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Oct 11, 2024
@haircommander haircommander moved this from Not for release to Removed in SIG Node 1.32 KEPs planning Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffromani ffromani

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
1.32 Enhancements Tracking
Status: Deferred
SIG Node 1.32 KEPs planning
Status: Removed
Milestone
No milestone
Development

No branches or pull requests