Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Storage Metrics #363

Closed
jingxu97 opened this issue Jul 26, 2017 · 10 comments
Closed

Expose Storage Metrics #363

jingxu97 opened this issue Jul 26, 2017 · 10 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@jingxu97
Copy link
Contributor

jingxu97 commented Jul 26, 2017

Feature Description

  • One-line feature description (can be used as a release note): Expose storage metrics to end users
  • Primary contact (assignee): @vkamra @jingxu97
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): Proposal for Exposing Storage Metrics community#855
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @derekwaynecarr, @vishh, @dashpole
  • Approver (likely from SIG/area to which feature belongs): @thockin, @vishh, @derekwaynecarr
  • Feature target (which target equals to which milestone):
    • Stable release target (x.y): 1.8/1.9
@jingxu97 jingxu97 added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 26, 2017
@jingxu97 jingxu97 self-assigned this Jul 26, 2017
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 26, 2017
@idvoretskyi idvoretskyi added this to the 1.8 milestone Jul 26, 2017
@tamalsaha
Copy link
Member

cc: @aerokite

k8s-github-robot pushed a commit to kubernetes/community that referenced this issue Aug 30, 2017
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](#855)

Feature: [#363](kubernetes/enhancements#363)
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 1, 2017
Automatic merge from submit-queue (batch tested with PRs 51513, 51515, 50570, 51482, 51448)

Add PVCRef to VolumeStats

**What this PR does / why we need it**:
For pod volumes that reference a PVC, add a PVCRef to the corresponding
volume stat. This allows metrics to be indexed/queried by PVC name
which is more user-friendly than Pod reference

**Which issue this PR fixes** : [#363](kubernetes/enhancements#363)

**Special notes for your reviewer**:

**Release note**:
```
`VolumeStats` reported by the kubelet stats summary API 
(http://<node>:10255/stats/summary) now include a PVCRef
field describing the PVC referenced by the volume (if any). 
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 3, 2017
Automatic merge from submit-queue

Expose PVC metrics via kubelet prometheus

This depends on #51448, opening early though. second commit is mine and mostly a copy/paste job.

implements metrics listed in here kubernetes/community#855 following method here kubernetes/community#930 (comment)

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: kubernetes/enhancements#363

**Special notes for your reviewer**:

**Release note**:

```release-note
PersistentVolumeClaim metrics like "volume_stats_inodes" and "volume_stats_capacity_bytes" are now reported via kubelet prometheus
```
@idvoretskyi
Copy link
Member

@jingxu97 please, update the features tracking board with the relevant data.

@jingxu97 jingxu97 removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 14, 2017
@jdumars
Copy link
Member

jdumars commented Sep 15, 2017

@jingxu97 any update on missing docs? PR is due today.

@idvoretskyi idvoretskyi added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Sep 19, 2017
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 22, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Add e2e test to verify PVC metrics

Adds an e2e test for kubernetes/enhancements#363

fixes #52459
erinboyd pushed a commit to erinboyd/community that referenced this issue Oct 23, 2017
Flushes out details for part 1 of the changes described in
kubernetes#855

Feature: kubernetes/enhancements#363
erinboyd pushed a commit to erinboyd/community that referenced this issue Oct 23, 2017
Flushes out details for part 1 of the changes described in
kubernetes#855

Feature: kubernetes/enhancements#363
@andyxning
Copy link
Member

andyxning commented Nov 2, 2017

@jingxu97 @vishh I am currently work on adding disk io quota to Kubernetes and adding disk io metrics to heapster. What is the currently status about this?

BTW, i will update heapster #1450 ASAP.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 2, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@PravinMagdum
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@PravinMagdum: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes#363
justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[kubernetes#855](kubernetes/community#855)

Feature: [kubernetes#363](kubernetes#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Nov 30, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Nov 30, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Nov 30, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
@siddhantvirus
Copy link

@tamalsaha @jingxu97 It seems like this is yet to be implemented.

I have gone through most linked issues and it seems like the design proposal was updated but we didn't work on this.

I'm also trying to figure out an implementation for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

9 participants