Proposal for Exposing Storage Metrics #855

jingxu97 · 2017-07-26T19:40:28Z

This proposal is exploring ways of exposing storage metrics to users

jingxu97 · 2017-08-02T17:34:32Z

cc @kubernetes/sig-instrumentation-feature-requests @kubernetes/sig-storage-feature-requests

brancz · 2017-08-03T09:18:39Z

contributors/design-proposals/storage-metrics.md

+
+| Metric name | Metric type | Labels/tags |
+|-------------|-------------|-------------|
+| volume_stats_capacityBytes | Gauge | namespace=\<persistentvolumeclaim-namespace\> <br/> persistentvolumeclaim=\<persistentvolumeclaim-name\>  <br/> persistentvolume=\<persistentvolume-name\> |


mixed snake and camel case

brancz · 2017-08-03T09:19:36Z

contributors/design-proposals/storage-metrics.md

+}
+
+// PVCReference contains enough information to locate the referenced PVC.
+type PodReference struct {


Comment says PVCReference, struct name is PodReference

brancz · 2017-08-03T09:19:56Z

contributors/design-proposals/storage-metrics.md

+}
+
+// PVReference contains enough information to locate the referenced PV.
+type PodReference struct {


comment says PVReference, struct name is PodReference

zhangxiaoyu-zidif · 2017-08-30T08:21:23Z

contributors/design-proposals/storage-metrics.md

+
+
+## Goals
+The gola of this proposal is to expose storage usage metrics to users for monitoring their storage systems.


Is this feature on pod-level ?

I think the metric is per volume. Could you explain what you mean by "pod-level"?

spell: s/gola/goal/

Automatic merge from submit-queue Proposal for adding PVC info to VolumeStats Flushes out details for part 1 of the changes described in [#855](#855) Feature: [#363](kubernetes/enhancements#363)

Automatic merge from submit-queue Expose PVC metrics via kubelet prometheus This depends on #51448, opening early though. second commit is mine and mostly a copy/paste job. implements metrics listed in here kubernetes/community#855 following method here kubernetes/community#930 (comment) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: kubernetes/enhancements#363 **Special notes for your reviewer**: **Release note**: ```release-note PersistentVolumeClaim metrics like "volume_stats_inodes" and "volume_stats_capacity_bytes" are now reported via kubelet prometheus ```

piosz · 2017-09-07T11:55:16Z

Is this ready for review? I still can see [WIP] tag in the first line of the doc.

derekwaynecarr · 2017-09-08T16:38:11Z

contributors/design-proposals/storage-metrics.md

+
+### volume usage information indexed by PVC/PV in Kubelet Summary API
+
+The basic idea is to cache PVC and the volume information in kubelet volume manager which is similar to caching the pod and volume information. In Summary API, In Summary API, we could add PVC and PV references into VolumeStats which is included in PodStats.


nit: double "In Summary API"

nit: incomplete sentence? "The second part is to register the volume metrics to ."

Flushes out details for part 1 of the changes described in kubernetes#855 Feature: kubernetes/enhancements#363

k8s-github-robot · 2017-11-17T08:06:19Z

This PR hasn't been active in 61 days. It will be closed in 28 days (Dec 16, 2017).

cc @jingxu97 @piosz

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

fejta-bot · 2018-02-15T08:31:04Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2018-03-17T09:17:50Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot · 2018-04-16T09:34:51Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Flushes out details for part 1 of the changes described in kubernetes/community#855 Feature: kubernetes#363

Automatic merge from submit-queue Proposal for adding PVC info to VolumeStats Flushes out details for part 1 of the changes described in [kubernetes#855](kubernetes/community#855) Feature: [kubernetes#363](kubernetes#363)

dioguerra · 2019-04-26T10:03:10Z

Status?
Was it done?

nodesocket · 2020-01-29T21:29:02Z

👍 I'd like to view how much of a persistent volume is in use and don't know of a way.

Flushes out details for part 1 of the changes described in kubernetes/community#855 Feature: kubernetes/enhancements#363