Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for recreation of pods once fully terminated in the job controller #3939

Open
8 tasks done
kannon92 opened this issue Apr 3, 2023 · 39 comments · Fixed by kubernetes/kubernetes#119301
Open
8 tasks done
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@kannon92
Copy link
Contributor

kannon92 commented Apr 3, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 3, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Apr 7, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 7, 2023
@wangyysde
Copy link
Member

/cc @wangyysde

@kannon92 kannon92 changed the title Terminating pods are included as active pods in Jobs and Deployments Consider Terminating pods as active pods in Jobs. May 1, 2023
@kannon92 kannon92 changed the title Consider Terminating pods as active pods in Jobs. Allow for recreation of pods once fully terminated in the job controller May 16, 2023
@alculquicondor
Copy link
Member

/assign
I'm taking over the KEP while @kannon92 is on PTO

@soltysh
Copy link
Contributor

soltysh commented Jun 1, 2023

/stage alpha
/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 1, 2023
@aramase
Copy link
Member

aramase commented Jun 14, 2023

Hello @alculquicondor 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hey @alculquicondor @kannon92
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@kannon92
Copy link
Contributor Author

Thank you so much to @alculquicondor for taking this over while I was on PTO. It is so exciting to see that this is tracked for this release. @alculquicondor reached out and I will take over the implementation of this PR.

/assign

@aramase
Copy link
Member

aramase commented Jul 17, 2023

Hey again @alculquicondor @kannon92 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

If there are any other k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Thanks for filling an exception request! I'll reapply the v1.28 milestone if the exception request is approved.

@Atharva-Shinde
Copy link
Contributor

/milestone clear

@npolshakova
Copy link

Hello @dejanzele, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@soltysh
Copy link
Contributor

soltysh commented Oct 3, 2023

/label lead-opted-in
/stage beta
/milestone v1.29

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Oct 3, 2023
@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Oct 4, 2023

Hello @kannon92 @dejanzele 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29(correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, everything is taken care of in #4252. Please make sure that the PR is merged in time for the enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova
Copy link

With KEP PR enhancements/pull/4252 approved, the enhancement is ready for the enhancements freeze.
The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

@katcosgrove
Copy link

Hey there @alculquicondor @kannon92 and @dejanzele 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@katcosgrove
Copy link

Hi again @alculquicondor @kannon92 and @dejanzele! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@alculquicondor
Copy link
Member

Thanks for the reminder. I created kubernetes/website#43529

@kannon92 could you update the issue description?

@kcmartin
Copy link

Hi @kannon92 @alculquicondor @dejanzele 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@alculquicondor
Copy link
Member

Thanks for the reminder @kcmartin. We did one for 1.28 https://kubernetes.io/blog/2023/08/21/kubernetes-1-28-jobapi-update/
We are not thinking of another one this time.

@sreeram-venkitesh
Copy link
Member

Hey again @kannon92 @dejanzele @alculquicondor! 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

This KEP is tracked for code freeze since all the associated code PRs have been merged for the beta stage and has been updated in the issue description 🎉

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@sreeram-venkitesh
Copy link
Member

Hello @kannon92 @dejanzele @alculquicondor 👋, 1.29 Enhancements team here!

With all the implementation (code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

Please let me know if there are additional test PRs we should track. Thanks!

@alculquicondor
Copy link
Member

The open PR just updates the KEP with the changes we decided during the implementation reviews. But all the test code is already merged.

@sreeram-venkitesh
Copy link
Member

Ah okay, thanks for clarifying! This means that there are no more PRs to be merged into k/k for this KEP right?

@dejanzele
Copy link

@sreeram-venkitesh, In my opinion, we merged everything which is required for PodReplacementPolicy to go into Beta and the requirements are done.

@kannon92
Copy link
Contributor Author

k/website is not quite done but code freeze wise, we are looking good.

@kannon92
Copy link
Contributor Author

I updated this checklist. I think we have each component necessary for 1.29 now and we are good to go for 1.29. Thank you @dejanzele for leading this effort. And thank you to @alculquicondor for doing the necessary docs updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked for Code Freeze
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.