-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support image pull per runtime class #4216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/sig windows |
/milestone v1.29 |
/label lead-opted-in |
Hello @kiashok 👋, Enhancements team here. Just checking in as we approach enhancements freeze on Friday, 6th October 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to add/update the following:
The status of this enhancement is marked as |
Hi @sanchita-07 , thanks a lot for the note. I have updated the KEP PR with your suggestions and I also requested for PRR review from the slack channel. Please let me know if there is anything more I need to do. Thanks! |
Thanks @npolshakova . @marosset reviewed the KEP today and set this label. |
We just need the PR #4217 to be merged, then we are good to go to mark the status as |
@sanchita-07 could you please help assign a PRR reviewer? Thanks. |
It looks like @johnbelamaric has been assigned and looking over it. |
Hello @kiashok 👋, Enhancement Lead here. This enhancement is |
Hi @npolshakova , I am addressing the comments now. The comments are only around restructuring some sentences and have no impact on the design that the KEP is talking about. It should not affect the KEP for 1.29 cc @jsturtevant @aravindhp @mrunalp @marosset @johnbelamaric @mikebrow |
FYI: opened PR #4283 to address the changes |
Hey there @kiashok! 👋, v1.29 Docs Lead here. |
I'll take a look at this tomorrow and share an update. Thanks! Also what is the code freeze date for alpha changes of the KEP? |
@a-mccarthy I already opened one two weeks ago: #4216 (comment) |
Follow up discussion to be had in sig-node for beta version: kubernetes/kubernetes#121658 |
@kiashok, that looks like a PR for docs changes. If you would like to also write a blog for this change, please create a separate placeholder PR by November 14th. Thanks! |
kubernetes/website#43923 @a-mccarthy . I will have the actual changes go out early tomorrow |
/remove-label lead-opted-in |
Hello 👋 1.30 Enhancements Lead here, I'm closing milestone 1.29 now, /milestone clear |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
containerd is adding the capability of pulling images with different snapshotters, based on the pod's runtime handler. So if kubelet requests containerd to pull image per runtime class, then containerd might pull them with different snapshotters. And since each snapshotter keeps its own imageFs usage, this will cause trouble for kubelet's tracking of imageFs usage. More spefically, kubelet currently only reads the imagefs usage of containerd's global snapshotter ([1] [2]), so if we pull a lot of images thru a non-global snapshotter, the disk usage will be ignored. I cannot think of any easy way to address this, mostly because kubelet's cri_stats_provider doesn't know which pods are using which snapshotter. Should we add this in to the scope of this KEP, to make sure kubelet either track imageFs usage per runtime class, or kubelet combine the imageFs of all snapshotters. |
@ruiwen-zhao I think this is a problem that exists even today, so I don't think we need to block this KEP on that. We could try and address it for GA of this KEP/feature. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/remove-lifecycle rotten It seems to be doable to promote this to Beta. |
@pacoxu: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enhancement Description
k/enhancements
) update PR(s): 4216: Image pull per runtime class KEP #4217k/k
) update PR(s):k/website
) update PR(s): Add docs for KEP 4216: Image pull per runtime class website#43541k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: