Allow almost all printable ASCII characters in environment variables

[HirazawaUi]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow special characters in environment variables
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4369-allow-special-characters-environment-variable/README.md
• Discussion Link: Environment variables containing colon not allowed kubernetes#53201
• Primary contact (assignee): @HirazawaUi
• Responsible SIGs:
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.30
  • Beta release target (x.y): 1.32
  • Stable release target (x.y): 1.34
• Alpha
  • KEP (k/enhancements) update PR(s):
    • Allow almost all printable ASCII characters in environment variables #4373
    • KEP-4396: promote kep into implementable #4482
  • Code (k/k) update PR(s):
    • Allow almost all printable ASCII characters in environment variables kubernetes#123385
  • Docs (k/website) update PR(s):
    • Document option to allow almost all printable ASCII characters in environment variables website#45125
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP-4369: Promote to beta (allow ~all ASCII characters in env vars) #4805
  • Code (k/k) update PR(s):
    • KEP-4369: promote RelaxedEnvironmentVariableValidation feature gate to beta kubernetes#126897
  • Docs (k/website) update(s):
    • Promote RelaxedEnvironmentVariableValidation to beta website#47663

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kikisdeliveryservice]

@HirazawaUi Can you check and find out which sig will be owning this enhancement and update this issue.

[HirazawaUi]

@HirazawaUi Can you check and find out which sig will be owning this enhancement and update this issue.

I think it should be sig-node

[HirazawaUi]

/sig node
/sig api-machinery
/cc @liggitt @thockin

[thockin]

Agree sig-node

[tjons]

Hello @HirazawaUi 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

• Merge the KEP readme into the k/enhancements repo.
• Complete the PRR review process and merge it into k/enhancements.
• Mark this KEP as implementable for latest-milestone: 1.30.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[HirazawaUi]

The status of this enhancement is marked as at risk for enhancement freeze

I will try to finish it.

[thockin]

https://github.com/kubernetes/enhancements/pull/4478/files

[tjons]

@HirazawaUi everything looks good except I'm not sure that the KRR has final approval from @jpbetz - what is the status?

[tjons]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

Actually, @HirazawaUi I was incorrect. This PR is also missing the v1.30 milestone in the Github issue. Therefore, unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

[salehsedghpour]

/milestone clear

[HirazawaUi]

This PR is also missing the v1.30 milestone in the Github issue.

It's very sad.
I took a closer look at the exception description and realized that this enhancement doesn't seem to apply to it very well, and there's no reason we have to implement this enhancement in milestone 1.30, so I decided to move forward with it in 1.31.

[HirazawaUi]

/milestone v1.31

[k8s-ci-robot]

@HirazawaUi: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kannon92]

Yes. #4805

[haircommander]

/milestone v1.32
/label lead-opted-in

[jenshu]

Hello @HirazawaUi 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage beta for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• Under Monitoring Requirements can you please also add the questions from the template?
• In your kep.yaml, you need to update the latest-milestone to v1.32 (this should be taken care of once the currently open PR merges)
• Your PRR needs a line specifying stage beta and an approver (this should be taken care of once the currently open PR merges)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[thockin]

@HirazawaUi please make sure you update this, or risk getting dropped!

[HirazawaUi]

@HirazawaUi please make sure you update this, or risk getting dropped!

OK, thanks for the reminder.

[jenshu]

Hi @HirazawaUi, thanks for updating the kep.yaml and PRR. I've updated the status to tracked for enhancements freeze for 1.32

[hacktivist123]

Hello @HirazawaUi 👋 1.32 Docs Shadow here.

Does this enhancement work planned for 1.32 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[hacktivist123]

Hello, @HirazawaUi 👋 1.32 Docs Shadow here.

This is just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday, Oct 24 at 18:00 PDT.
Thanks! 🚀

[HirazawaUi]

The PR for the docs has been opened and is associated with this issue

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[jenshu]

Hello @HirazawaUi 👋, v1.32 Enhancements team here.

With all the implementation (code related) PRs merged per the issue description:

• KEP-4369: promote RelaxedEnvironmentVariableValidation feature gate to beta kubernetes#126897

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

[dipesh-rawat]

Hello 👋, 1.33 Enhancements Lead here.

I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in
/milestone clear

[HirazawaUi]

@haircommander Could you add lead-opted-in label to this feature? I hope to move it forward in version 1.33.

[haircommander]

these days, KEPs often stay in beta for two releases before being GA'd. Is there a reason to move forward now rather than in 1.34?

[HirazawaUi]

Thank you for the reminder. In my initial KEP formulation, I had set the interval between beta and GA to span one release. I agree to continue advancing it in version 1.34, hoping it will receive sufficient feedback during the testing phase.