New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl get and describe should work well with extensions #515

Open
smarterclayton opened this Issue Nov 21, 2017 · 25 comments

Comments

@smarterclayton
Contributor

smarterclayton commented Nov 21, 2017

Feature Description

  • One-line feature description (can be used as a release note): kubectl get should get columns back from the server, not the client, to allow extensions to work cleanly
  • Primary contact (assignee): smarterclayton
  • Responsible SIGs: sig-cli, sig-api-machinery
  • Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/server-get.md
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: pwittrock soltysh
  • Approver (likely from SIG/area to which feature belongs): pwittrock soltysh
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.8 (server API)
    • Beta release target (x.y): 1.10 (client get, server API)
    • Stable release target (x.y): ? (client get, server API)

As part of the split of kubectl from close coupling with the repository, and to allow better extensibility, it should be possible for third party API extensions and CRD to provide custom output for kubectl get to avoid kubectl having to have code to interpret those resources. We will move the printing to the server side, and kubectl will retrieve results. We also wish to move describe in a future release.

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Nov 21, 2017

Client side and beta API targeted for 1.10

@idvoretskyi

This comment has been minimized.

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Jan 15, 2018

We're trying to close the loop on the 1.10 plan

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@smarterclayton any progress?

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Jan 22, 2018

Yes, we are planning to bring this to beta in 1.10. Work is being tracked in kubernetes/kubernetes#58536

@Bradamant3

This comment has been minimized.

Member

Bradamant3 commented Mar 6, 2018

@smarterclayton sorry, I thought I had pinged you about this earlier. If this feature needs docs, can you please get a PR in in the next day or so? We need to merge all docs PRs by this Friday (March 9). If not, can you please indicate on the feature tracking spreadsheet? Thanks!

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Mar 6, 2018

@juanvallejo can you add a doc?

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Mar 6, 2018

@smarterclayton sure, will add doc

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@smarterclayton
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@smarterclayton smarterclayton modified the milestones: v1.10, v1.11 Apr 18, 2018

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Apr 18, 2018

@juanvallejo can you add details about the 1.11 planned things? I think we should try to get custom CRD columns on the server side in 1.11 with a minimal alpha api. I can bump the stable target to 1.12

@soltysh

This comment has been minimized.

Contributor

soltysh commented Apr 18, 2018

The current tracking issue can be found in kubernetes/kubernetes#60712.
+1 for bumping this to stable in 1.12.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 20, 2018

Thanks for the update!

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@justaugustus Does this need to be removed from the spreadsheet?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 1, 2018

@mistyhacks just fixed it!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@soltysh @smarterclayton @juanvallejo @kubernetes/sig-api-machinery-feature-requests @kubernetes/sig-cli-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 31, 2018

@soltysh @smarterclayton @juanvallejo --
Feature Freeze is today. Are we planning on graduating this feature in Kubernetes 1.12?
If so, can you make sure everything is up-to-date, so I can include it on the 1.12 Feature tracking spreadsheet?

@soltysh

This comment has been minimized.

Contributor

soltysh commented Jul 31, 2018

@justaugustus I've updated the description, and moved the target stable from 1.12 to 1.13. We need to stabilize current API a bit more. And there are still some bits and nits that needs fixing. So that's what we'll focus on in 1.12.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 31, 2018

Sounds good. Thanks for the update, @soltysh!

@justaugustus justaugustus modified the milestones: v1.12, v1.13 Jul 31, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 31, 2018

/remove-stage beta
/stage stable

@dims dims referenced this issue Aug 24, 2018

Open

Server-side printing continued #60712

5 of 13 tasks complete

@kacole2 kacole2 added the tracked/yes label Oct 8, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@soltysh what work if left in k/k for this feature to go to stable in 1.13? Is there a list of pending PRs (code, tests and docs) that we can track on our end? how confident are you in stabilizing the API in the short 1.13 timeframe ?

@guineveresaenger

This comment has been minimized.

guineveresaenger commented Oct 22, 2018

Hi @soltysh There has been no communication on the status of this enhancement and I could not find any linked pull requests. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me or @kacole2 know where we stand. Thanks!

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 24, 2018

/milestone clear

@kacole2 kacole2 removed the tracked/yes label Oct 24, 2018

@kacole2 kacole2 removed this from the v1.13 milestone Oct 24, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 24, 2018

@soltysh this enhancement has been moved out of 1.13 due to lack of clarity on whats pending for this to land . We are officially in Enhancement freeze now. Should you need this added back in it will require filing an exception.

@soltysh

This comment has been minimized.

Contributor

soltysh commented Oct 26, 2018

@AishSundar sorry for getting to it that late, I'm fine moving it further. We're still working on other related stuff, so this will not go into stable in 1.13. We need 100% confidence before we do so, that's why I removed any version from stable stage in the original description.

@AishSundar

This comment has been minimized.

AishSundar commented Oct 26, 2018

Ack that and thanks @soltysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment