Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance profiles summary and motivation #1619

Merged
merged 4 commits into from Apr 22, 2020
Merged

Conformance profiles summary and motivation #1619

merged 4 commits into from Apr 22, 2020

Conversation

johnbelamaric
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 18, 2020
@johnbelamaric
Copy link
Member Author

/assign @hh @Jefftree @smarterclayton
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 18, 2020
@johnbelamaric johnbelamaric mentioned this pull request Mar 18, 2020
Closed
@johnbelamaric
Copy link
Member Author

This is a start on the profiles KEP, still a WIP of course.

/cc @WilliamDenniss @spiffxp

@johnbelamaric
Copy link
Member Author

/hold
for all approvals (also still a WIP)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@spiffxp spiffxp added this to To Triage in conformance-definition via automation Apr 7, 2020
@spiffxp spiffxp moved this from To Triage to Needs Review in conformance-definition Apr 7, 2020
@hh
Copy link
Member

hh commented Apr 20, 2020

I think this gets us to our initial stages.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hh, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

derekwaynecarr
derekwaynecarr reviewed Apr 21, 2020
View reviewed changes
keps/sig-architecture/1618-conformance-profiles/README.md

- Should be able to define which tests to run up-front (eg: conformance, plus
profiles, profiles only, etc)
- May be able to detect or enumerate list of eligible profiles for a given
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this via some query-able endpoint under discussion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of polling for features would be great.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't ironed out the technical details yet, but this is a great suggestion.

spiffxp
spiffxp reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two questions but otherwise looks good

keps/sig-architecture/1618-conformance-profiles/README.md
behavior definitions.
* Design and implement a mechanism to validate whether a cluster conforms to
each profile.
* Document guidance on how to choose the scope of individual profiles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and restrict the total number of profiles?

keps/sig-architecture/1618-conformance-profiles/README.md

As a developer of an optional feature, I must be able to define behaviors for
that feature that a vendor claiming support for the feature must follow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whose responsibility is it to assign optional features to Profiles / create new Profiles?

I feel like as a developer I need to know this information if I want my feature to be included in Conformance testing.

OTOH, maybe inclusion in a Profile is up to someone else to decide

keps/sig-architecture/1618-conformance-profiles/README.md
like you have a storage driver, etc)
- Need to be able to selectively schedule Profile tests to nodes that support
them (eg: Windows to windows nodes, GPU to nodes that have gpus, etc.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming roles related to certification are going to be done as a followup

@johnbelamaric
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6b1b010 into kubernetes:master Apr 22, 2020
conformance-definition automation moved this from Needs Review to Done Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 22, 2020
@johnbelamaric johnbelamaric deleted the conformance-profiles branch February 2, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hh hh hh left review comments

@spiffxp spiffxp spiffxp left review comments

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@Jefftree Jefftree Jefftree left review comments

@dims dims Awaiting requested review from dims

@WilliamDenniss WilliamDenniss Awaiting requested review from WilliamDenniss

Assignees

@hh hh

@smarterclayton smarterclayton

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@johnbelamaric @hh @k8s-ci-robot @spiffxp @derekwaynecarr @Jefftree @smarterclayton