-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRR Approval for Beta of efficient watch resumption KEP #2274
PRR Approval for Beta of efficient watch resumption KEP #2274
Conversation
9d51def
to
9b33e77
Compare
@@ -13,6 +13,7 @@ approvers: | |||
- "@deads2k" | |||
- "@lavalamp" | |||
prr-approvers: | |||
- "@deads2k" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k - please review in the already committed file:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption#production-readiness-review-questionnaire
[I will update if needed]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k - please review in the already committed file:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption#production-readiness-review-questionnaire[I will update if needed]
you owe a manual upgrade/downgrade/upgrade test this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I will do that (though may not get to it before feature freeze before when this KEP needs to be merged).
Will send a PR with KEP update when this is done.
See #2281 Also you need to set the |
9b33e77
to
cffa4ed
Compare
@deads2k - please take a look |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref #1904
Follow up from: #2267
I filled in the PRR in: #2267 and apparently forgot to "git add" the PRR file :(
I Daniel approved that in the meantime :)
/assign @deads2k