Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRR Approval for Beta of efficient watch resumption KEP #2274

Merged

Conversation

wojtek-t
Copy link
Member

Ref #1904

Follow up from: #2267

I filled in the PRR in: #2267 and apparently forgot to "git add" the PRR file :(
I Daniel approved that in the meantime :)

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2021
@wojtek-t wojtek-t force-pushed the efficient_watch_resumption_beta_prr branch from 9d51def to 9b33e77 Compare January 15, 2021 12:39
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2021
@@ -13,6 +13,7 @@ approvers:
- "@deads2k"
- "@lavalamp"
prr-approvers:
- "@deads2k"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k - please review in the already committed file:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption#production-readiness-review-questionnaire

[I will update if needed]

you owe a manual upgrade/downgrade/upgrade test this release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I will do that (though may not get to it before feature freeze before when this KEP needs to be merged).
Will send a PR with KEP update when this is done.

@johnbelamaric
Copy link
Member

johnbelamaric commented Jan 15, 2021

See #2281

Also you need to set the stage to beta here.

@wojtek-t wojtek-t force-pushed the efficient_watch_resumption_beta_prr branch from 9b33e77 to cffa4ed Compare January 18, 2021 08:10
@wojtek-t
Copy link
Member Author

@deads2k - please take a look

@deads2k
Copy link
Contributor

deads2k commented Jan 19, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9ad848a into kubernetes:master Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants