Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-277: Target GA in 1.25 #3384

Merged
merged 1 commit into from Jun 21, 2022
Merged

KEP-277: Target GA in 1.25 #3384

merged 1 commit into from Jun 21, 2022

Conversation

verb
Copy link
Contributor

@verb verb commented Jun 10, 2022

  • One-line PR description: Mark KEP-277 (Ephemeral Containers) as targeting stable for 1.25
  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2022
@verb
Copy link
Contributor Author

verb commented Jun 10, 2022

/test all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 10, 2022
@verb verb force-pushed the 1.25-ga branch 2 times, most recently from acc677a to aad54a3 Compare June 10, 2022 16:31
@verb
Copy link
Contributor Author

verb commented Jun 10, 2022

/retest

@verb verb marked this pull request as ready for review June 10, 2022 16:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2022
@verb
Copy link
Contributor Author

verb commented Jun 10, 2022

/assign @dchen1107

@dchen1107
Copy link
Member

/lgtm
/approve

Meanwhile, I asked few vendors to collect some user feedbacks on the feature.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 11, 2022
Closed
23 tasks
@wojtek-t
Copy link
Member

/assign @johnbelamaric

@dchen1107 dchen1107 added this to the v1.25 milestone Jun 14, 2022
johnbelamaric
johnbelamaric reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor questions but looks ok

keps/sig-node/277-ephemeral-containers/kep.yaml Outdated Show resolved Hide resolved
keps/sig-node/277-ephemeral-containers/README.md
@@ -831,16 +946,30 @@ _This section must be completed when targeting beta graduation to a release._
ephemeral containers. We'll investigate whether it's possible to add ephemeral
containers to these existing tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any luck with this? Or could you do it in 1.25?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't get these added last time and now it looks like this link is broken. I'm going to add node conformance tests for 1.25, so I can take another look here. I'll ask around in slack if I can't find the right place to put it.

@pacoxu pacoxu added this to Waiting on Author in SIG Node PR Triage Jun 20, 2022
@pacoxu pacoxu moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Jun 20, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
johnbelamaric
johnbelamaric reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, johnbelamaric, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@johnbelamaric
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 321b82a into kubernetes:master Jun 21, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@palnabarun palnabarun palnabarun left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dchen1107 dchen1107

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@verb @k8s-ci-robot @dchen1107 @wojtek-t @johnbelamaric @palnabarun