Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdrawn the CephFS in-tree provisioner to CSI driver migration kep #4035

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented May 25, 2023

  • One-line PR description: updating milestone

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2023
@carlory carlory changed the title KEP-2923 update rbd migration feature milestone in KEP to 1.28 [WIP] KEP-2923 Deprecation of intree CephFS driver in 1.28 May 26, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@humblec
Copy link
Contributor

humblec commented May 26, 2023

@carlory just wanted to make a couple of things clear :

There are 2 volume plugins with Ceph which we are marking for deprecation in this release v1.28.

  1. CephFS driver:
  2. Ceph RBD driver:

The CephFS driver deprecation PR is here : kubernetes/kubernetes#118143 based on https://groups.google.com/g/kubernetes-sig-storage/c/IlHnIpwTbEg

The Ceph RBD driver deprecation PR has not filed yet , but will be soon. The announcement is here https://groups.google.com/g/kubernetes-sig-storage/c/h5751_B5LQM

Just mentioning this details as the title of this PR says CephFS, but the issue points to RBD.

@carlory
Copy link
Member Author

carlory commented May 27, 2023

@humblec Thank you for pointing out my mistake, I will fix it later.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2023
@carlory
Copy link
Member Author

carlory commented May 28, 2023

Based on https://groups.google.com/a/kubernetes.io/g/dev/c/g8rwL-qnQhk, CephFS in-tree volume plugin ( kubernetes.io/cephfs) will be deprecated in v1.28. Becase kubernetes/kubernetes#111137 isn't merged, kep-2924 is unimplemented until now.

we should withdraw this KEP.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2023
@carlory carlory changed the title [WIP] KEP-2923 Deprecation of intree CephFS driver in 1.28 KEP-2923 Deprecation of intree CephFS driver in 1.28 May 28, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2023
@carlory
Copy link
Member Author

carlory commented May 28, 2023

/cc @humblec @msau42 @saad-ali

@k8s-ci-robot k8s-ci-robot requested a review from humblec May 28, 2023 10:54
@humblec
Copy link
Contributor

humblec commented Jun 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit a508533 into kubernetes:master Jun 14, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 14, 2023
@xing-yang
Copy link
Contributor

@humblec @carlory Can you please add deprecation release notes to this PR similar to what's in the Ceph RBD PR?

@carlory
Copy link
Member Author

carlory commented Aug 11, 2023

@xing-yang kubernetes/kubernetes#118143 deprecate CephFS plugin from available in-tree drivers

/retitle withdrawn the CephFS in-tree provisioner to CSI driver migration kep

@k8s-ci-robot k8s-ci-robot changed the title KEP-2923 Deprecation of intree CephFS driver in 1.28 withdrawn the CephFS in-tree provisioner to CSI driver migration kep Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants