Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CSIMigrationRBD feature promotion from alpha to deprecation #41329

Merged
merged 1 commit into from
Jul 25, 2023
Merged

add CSIMigrationRBD feature promotion from alpha to deprecation #41329

merged 1 commit into from
Jul 25, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented May 25, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone May 25, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 25, 2023
@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 25, 2023 16:36
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2023
@tengqm
Copy link
Contributor

tengqm commented May 25, 2023

We are not supposed to merge this until the upstream source code is merged.
Please mark this as a WIP.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@carlory carlory changed the title add CSIMigrationRBD feature promotion from alpha to beta [WIP]add CSIMigrationRBD feature promotion from alpha to beta May 26, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@carlory carlory changed the title [WIP]add CSIMigrationRBD feature promotion from alpha to beta [WIP]add CSIMigrationRBD feature promotion from alpha to deprecation May 26, 2023
@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 400fbf9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64b49ecdefba310008770b3f

@carlory carlory changed the title [WIP]add CSIMigrationRBD feature promotion from alpha to deprecation add CSIMigrationRBD feature promotion from alpha to deprecation Jul 17, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2023
@carlory
Copy link
Member Author

carlory commented Jul 17, 2023

/hold cancel

cc @xing-yang

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@carlory
Copy link
Member Author

carlory commented Jul 25, 2023

/assign @tengqm

@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@carlory
Copy link
Member Author

carlory commented Jul 25, 2023

cc @xing-yang

@xing-yang
Copy link
Contributor

/assign @humblec

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2395f47f2ca68529f51f5f2748f82044aa254ec7

@k8s-ci-robot k8s-ci-robot merged commit 5ebbcf3 into kubernetes:dev-1.28 Jul 25, 2023
6 of 7 checks passed
@humblec
Copy link
Contributor

humblec commented Jul 25, 2023

/lgtm from my end too!

@humblec
Copy link
Contributor

humblec commented Jul 25, 2023 •
edited
Loading

@carlory can you please confirm the doc PR was filed for in-tree storage driver too ? I was keep tracking on it, however lost the track when few PRs came in between here and there.. just making sure the doc PRs for all three are covered here:

  1. in-tree storage driver deprecation for Ceph RBD Mention CephFS and RBD in-tree storage driver deprecation #42201
  2. in-tree storage driver deprecation for CephFS Mention CephFS and RBD in-tree storage driver deprecation #42201
  3. RBD CSI migration deprecation.. -> THIS PR .

Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41329 from carlory/kep-rbd-migration
a2d57c5 
add CSIMigrationRBD feature promotion from alpha to deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

@humblec humblec

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlory @tengqm @k8s-ci-robot @xing-yang @humblec