Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3751: Fix the definition of the VolumeAttributesClass #4116

Closed
wants to merge 1 commit into from
Closed

KEP-3751: Fix the definition of the VolumeAttributesClass #4116

wants to merge 1 commit into from

Conversation

carlory
Copy link
Member

@carlory carlory commented Jul 6, 2023

  • One-line PR description: Fix the definition of the VolumeAttributesClass

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from msau42 July 6, 2023 04:02
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 6, 2023
@carlory
Copy link
Member Author

carlory commented Jul 6, 2023

/test pull-enhancements-verify

@carlory carlory changed the title Fix the definition of the VolumeAttributesClass KEP-3751: Fix the definition of the VolumeAttributesClass Jul 6, 2023
@carlory
Copy link
Member Author

carlory commented Jul 6, 2023

/cc @sunnylovestiramisu

@sunnylovestiramisu
Copy link
Contributor

/assign

sunnylovestiramisu
sunnylovestiramisu reviewed Jul 14, 2023
View reviewed changes
keps/sig-storage/3751-volume-attributes-class/README.md

type VolumeAttributesClassSpec struct {
// Name of the driver
DriverName string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the driver name?

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jul 14, 2023
Open
11 tasks
@carlory carlory closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@msau42 msau42 Awaiting requested review from msau42

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlory @k8s-ci-robot @sunnylovestiramisu