Kubernetes VolumeAttributesClass ModifyVolume #3751
Comments
k8s-ci-robot
added
the
needs-sig
|
/sig storage |
k8s-ci-robot
added
sig/storage
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
xing-yang
added
stage/alpha
|
Hello @sunnylovestiramisu 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
sunnylovestiramisu
changed the title
xing-yang
removed
the
lead-opted-in
xing-yang
added
the
lead-opted-in
|
Hi @sunnylovestiramisu 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023. The status for this enhancement is For this KEP, we would just need to update the following:
Let me know if I missed anything. Thanks! |
xing-yang
changed the title
|
1.28 Docs Shadow here. Does this enhancement work planned for 1.28 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
|
@AdminTurnedDevOps I think we just need a placeholder PR so that the docs team can add it to tracking. I will follow the instructions, thanks! |
|
Hi @sunnylovestiramisu , Could you update the link of The pr link is difficult for users to learn the content of this KEP. |
|
Hey again @sunnylovestiramisu 👋 I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above. As always, we are here to help if any questions come up. Thanks! |
|
@salehsedghpour So far there was only one PR in review and I discussed with sig-storage lead @msau42 from now on we want to make sure the release in k8s and csi side cars all be ready before merging any PRs. We will move alpha completion to 1.29. |
|
@sunnylovestiramisu, to ensure we are on the same page, is there any plan to move ahead with the KEP in this release, or is it intended to be deferred to the next release which will result in marking it as Deferred to the next release? |
|
Deferred to the next release 1.29 is the intention @salehsedghpour |
|
/milestone v1.29 |
|
Hello @sunnylovestiramisu 👋, v1.29 Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
|
As the graduation criteria is updated and #4245 is merged, marking this as Tracked for Enhancements Freeze. |
|
Hey there @sunnylovestiramisu ! 👋, v1.29 Docs team shadow here. |
|
@Princesso For 1.29 we are planning to have the API and controller change ready but the quota + admission control will happen post 1.29. It does not seem like a good idea to have doc update while not everything is ready. What is the general practice here for docs? |
|
@sunnylovestiramisu I think it is fine to document what we will have. It will be marked as alpha. |
|
We did have a doc pr open but it got closed: kubernetes/website#41915 |
|
Thanks for the update @sunnylovestiramisu. I'll check in with the team and see what we need to do to move forward.:) |
|
Hi @sunnylovestiramisu, could you raise another PR? I checked and this one was for a blog and not docs. Kindly follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. |
|
@Princesso Created kubernetes/website#43463 |
|
kubernetes/website#43463 also looks like it's adding a blog article. |
|
Hi @sunnylovestiramisu! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release. It seems from the comment above that this may be the case, please confirm. If so, you need to open a PR placeholder in the website repository. |
|
Hey again @sunnylovestiramisu 👋, 1.29 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: . Here's where this enhancement currently stands:
Please update the Issue description to include all the related PRs of this KEP under the Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
|
Hello @sunnylovestiramisu 👋, 1.29 Release Team Lead here! could you please confirm if kubernetes/kubernetes#118863 part of code implementation PRs for this KEP? We're currently reviewing this KEP for 1.29 Code Freeze. 🙂 |
|
@Priyankasaggu11929 |
Thanks @sunnylovestiramisu! With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. Let me know if there any test PRs we should track. Thanks! |
Shadow contributions: - 1.27 shadow reviews: 6 - 1.28 shadow reviews: 9 - 1.29 - did not shadow due to time constraints with new SIG API Machinery TL role Planned contributions: - 1.30+ contribute to PRR, able to review roughly 12 KEPs per release. I am happy to PRR more than 12 so long as they are SIG API Machinery KEPs, since I'll be reviewing those anyway.. Shadow reviewer promotion criteria: Transitions from new to alpha - kubernetes#3983 - kubernetes#3751 Transitions from alpha to beta - kubernetes#3107 - kubernetes#2485 Transitions from beta to GA - kubernetes#2268 Three enhancements that require coordination between multiple components. - kubernetes#3751 - kubernetes#2485 - kubernetes#3107 Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile. - kubernetes#2268 (component skew) - kubernetes#2485 (component skew) - kubernetes#3751 (HA skew - feature gated fields, component skew) kubernetes#2268 (HA skew of controller considered) Three enhancements that are outside your primary domain. - kubernetes#3983 (SIG Node) - kubernetes#3751 (SIG Storage) - kubernetes#2268 (SIG Node) - kubernetes#3107 (SIG Storage) Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking. - Yes. E.g. kubernetes#2268 (ability to analyze cluster in aggregate considered, rescheduling considered) Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics. - Yes. E.g. kubernetes#3751 (new API call, volume of calls considered)
|
Yet this KEP scopes cgroups as a non-goal:
I'd like to point a cgroups configuration option in order to help the implementability of this KEP. Modifying cgroups directly from a CSI node driver could cause conflicts. "Too many cooks in the kitchen". However, the CSI node driver can connect to the NRI server in CRI-O or containerd. Once connected, the driver will receive pod and container lifecycle events, and it can modify all OCI parameters accordingly, including linux.resources.blockio. When the driver gets notified on a change in VolumeAttributesClass of a volume, the driver can immediately update OCI parameters of running containers, too, through the same NRI connection. Maybe this could be handled by a generic CSI sidecar container to help handling most common scenarios? |
Enhancement Description
One-line enhancement description (can be used as a release note): An extension to the Kubernetes Persistent Volume API to allow users to dynamically control volume options iops + throughput.
Kubernetes Enhancement Proposal: KEP-3751: Kubernetes VolumeAttributesClass ModifyVolume #3780
Discussion Link:
k/enhancements) update PR(s):k/k) update PR(s):k/website) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: