Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3960: promote to beta in 1.30 #4367

Merged
merged 1 commit into from Feb 2, 2024
Merged

KEP-3960: promote to beta in 1.30 #4367

merged 1 commit into from Feb 2, 2024

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Dec 20, 2023 •
edited

  • One-line PR description:
    Promote KEP-3960 to beta in 1.30
  • Other comments:

Works will be done for beta

  1. Add additional e2e test cases.
  2. Add one metric

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
@AxeZhan AxeZhan mentioned this pull request Dec 20, 2023
Open
8 tasks
@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 20, 2023

/cc @thockin

@wojtek-t wojtek-t self-assigned this Dec 20, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Dec 20, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Dec 22, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 22, 2023

And a draft code in k/k: kubernetes/kubernetes#122456

@AxeZhan
Copy link
Member Author

AxeZhan commented Jan 10, 2024

kindly ping @thockin

thockin
thockin reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kannon92 has one open

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2024
@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@thockin thockin added this to the v1.30 milestone Jan 24, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@thockin
Copy link
Member

thockin commented Jan 30, 2024

I am good with it - @kannon92 ?

/lgtm
/hold
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@thockin
Copy link
Member

thockin commented Jan 30, 2024

Oh, right - this being sig-node I can't approve anyway.

@SergeyKanzhelev @dchen1107 @mrunalp @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@wojtek-t
Copy link
Member

@wojtek-t Can you take a look at PRR? Since you reviewed PRR for this KEP in alpha, and there are only minor changes in beta.

yes - will review later this week

@AxeZhan
Copy link
Member Author

AxeZhan commented Jan 31, 2024

/cc @mrunalp @dchen1107 @SergeyKanzhelev @klueska

wojtek-t
wojtek-t reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment - other than that LGTM

keps/sig-node/3960-pod-lifecycle-sleep-action/README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
wojtek-t
wojtek-t reviewed Feb 2, 2024
View reviewed changes
keps/sig-node/3960-pod-lifecycle-sleep-action/README.md Outdated
Added in alpha:
Unit tests in `k8s.io/kubernetes/pkg/apis/core/validation_test` test the verification with feature-gate enabled.
The verification with feature-gate disabled is tested manually as it's hard to trigger `PrepareForCreate` strategy in unit tests.
E2e tests in `test/e2e/common/node/lifecycle_hook.go` test the behavior with feature-gate enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying from the KEP template:

Additionally, for features that are introducing a new API field, unit tests that
are exercising the `switch` of feature gate itself (what happens if I disable a
feature gate after having objects written with the new field) are also critical.
You can take a look at one potential example of such test in:
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282

I'm actually more interested in sth like that - this question is not about testing the feature itself (testing code with FG enabled), but rather testing the transition between enabled and disabled (and vice versa).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... Yea, I think we need a test like this for this feature. But I clearly misunderstood this and missed this in alpha🤦.
I'll bring this test in beta, I added some cases in Unit tests for beta.

@AxeZhan AxeZhan force-pushed the beta3960 branch 2 times, most recently from cb25915 to 61ffb47 Compare February 2, 2024 08:57
@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2024

Thanks!

/lgtm
/approve PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, mrunalp, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@AxeZhan
Copy link
Member Author

AxeZhan commented Feb 2, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit c80d6b2 into kubernetes:master Feb 2, 2024
4 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Feb 2, 2024
@AxeZhan AxeZhan mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@mrunalp mrunalp mrunalp approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@palnabarun palnabarun Awaiting requested review from palnabarun

@thockin thockin Awaiting requested review from thockin

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@klueska klueska Awaiting requested review from klueska

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@mrunalp mrunalp

@klueska klueska

@kannon92 kannon92

@thockin thockin

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@AxeZhan @thockin @kannon92 @wojtek-t @k8s-ci-robot @mrunalp @klueska @dchen1107 @SergeyKanzhelev