New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote kubectl debug to GA #4408
Promote kubectl debug to GA #4408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, can you update the format (mostly the questions in PRR) with the template https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md
- [ ] Test plan GA milestones reached | ||
- [ ] User feedback gathered over 2 release cycles. | ||
- [x] Test plan GA milestones reached | ||
- [x] User feedback gathered over 2 release cycles. | ||
- [ ] 3 external articles suggest using `kubectl debug` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick google search and I got (in no particular order):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Updated with the links above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
for sig-cli
/label tide/merge-method-squash |
PRR shadow This LGTM, I think most of PRR does not really apply to |
/approve @enj Yes, we see that with lots of the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, johnbelamaric, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubectl debug
to stable. In reality, this promotion seems like a more paperwork becausekubectl debug
has been used for nearly more than 3 years and this is a sufficient time to collect feedback, incorporate changes and add unit, integration tests(https://github.com/kubernetes/kubernetes/blob/master/test/cmd/debug.sh)