Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote kubectl debug to GA #4408

Merged
merged 3 commits into from Feb 6, 2024

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Jan 16, 2024

  • One-line PR description: This PR promotes kubectl debug to stable. In reality, this promotion seems like a more paperwork because kubectl debug has been used for nearly more than 3 years and this is a sufficient time to collect feedback, incorporate changes and add unit, integration tests(https://github.com/kubernetes/kubernetes/blob/master/test/cmd/debug.sh)
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 16, 2024
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2024
@ardaguclu ardaguclu mentioned this pull request Jan 16, 2024
4 tasks
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, can you update the format (mostly the questions in PRR) with the template https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2024
- [ ] Test plan GA milestones reached
- [ ] User feedback gathered over 2 release cycles.
- [x] Test plan GA milestones reached
- [x] User feedback gathered over 2 release cycles.
- [ ] 3 external articles suggest using `kubectl debug`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Updated with the links above.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
for sig-cli

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 16, 2024
@enj
Copy link
Member

enj commented Feb 5, 2024

PRR shadow

This LGTM, I think most of PRR does not really apply to kubectl debug. Since this whole flow is user initiated, there really aren't any novel concerns that are unique to kubectl debug that wouldn't apply equally to just using the REST API directly. Most of these pods are likely short lived so I see no significant concerns around resource consumption.

@johnbelamaric
Copy link
Member

/approve

@enj Yes, we see that with lots of the kubectl things, often many questions don't really apply.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, johnbelamaric, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit c9d7214 into kubernetes:master Feb 6, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 6, 2024
@ardaguclu ardaguclu deleted the kubectl-debug-stable branch February 7, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants