Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KEP for ingress API group move #749

Merged
merged 1 commit into from Feb 1, 2019
Merged

Add KEP for ingress API group move #749

merged 1 commit into from Feb 1, 2019

Conversation

bowei
Copy link
Member

@bowei bowei commented Jan 29, 2019

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/pm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2019
@bowei
Copy link
Member Author

bowei commented Jan 29, 2019

cc: @caseydavenport @aledbf

thockin
thockin reviewed Jan 29, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the general thrust. Give it some time to accumulate notes.

keps/sig-network/0034-20190125-ingress-api-group.md Outdated Show resolved Hide resolved
keps/sig-network/0034-20190125-ingress-api-group.md Outdated Show resolved Hide resolved
keps/sig-network/0034-20190125-ingress-api-group.md Outdated Show resolved Hide resolved
keps/sig-network/0034-20190125-ingress-api-group.md Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jan 29, 2019
View reviewed changes
keps/NEXT_KEP_NUMBER Outdated Show resolved Hide resolved
@bgrant0607
Copy link
Member

I think this is a necessary recognition of reality, as Ingress does have a number of implementations and users, and we need a stable L7 API by EOY.

@liggitt liggitt mentioned this pull request Jan 30, 2019
Closed
1 task
@liggitt
Copy link
Member

liggitt commented Jan 30, 2019

FYI, the deadline for merging and marking implementable got extended to monday because the originally documented requirements were unclear. Are there any other questions about the work being proposed for 1.14?

caseydavenport
caseydavenport reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowei this looks like a good plan to me, given what we've got to work with!

Looks like there are just a couple of comments to clean up.

@soltysh soltysh mentioned this pull request Jan 31, 2019
Closed
41 tasks
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Feb 1, 2019
@bowei
Copy link
Member Author

bowei commented Feb 1, 2019

@caseydavenport -- updated incorporating comments.

Note: had to move the file to match new KEP guidelines, so the existing github PR comments will probably be stale...

@caseydavenport
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, caseydavenport

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9357949 into kubernetes:master Feb 1, 2019
@bowei bowei deleted the ingress-api-group branch June 24, 2019 17:52
@hbagdi hbagdi mentioned this pull request Aug 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@caseydavenport caseydavenport caseydavenport left review comments

@thockin thockin thockin left review comments

@bgrant0607 bgrant0607 bgrant0607 left review comments

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@caseydavenport caseydavenport

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bowei @bgrant0607 @liggitt @caseydavenport @k8s-ci-robot @aledbf @smarterclayton @thockin @justaugustus